mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Adam Radford <aradford@gmail.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
	Hannes Reinecke <hare@suse.com>,
	Bradley Grove <linuxdrivers@attotech.com>,
	John Garry <john.garry@huawei.com>,
	Don Brace <don.brace@microsemi.com>,
	Xiang Chen <chenxiang66@hisilicon.com>,
	James Smart <james.smart@broadcom.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani  <suganath-prabu.subramani@broadcom.com>,
	Jack Wang <jinpu.wang@cloud.ionos.com>,
	Balsundar P <balsundar.p@microchip.com>
Cc: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-scsi@vger.kernel.org, esc.storagedev@microsemi.com,
	megaraidlinux.pdl@broadcom.com, MPT-FusionLinux.pdl@broadcom.com
Subject: [PATCH v4 13/29] scsi: hisi_sas_v3_hw: Don't use PCI helper functions
Date: Mon,  2 Nov 2020 22:17:14 +0530	[thread overview]
Message-ID: <20201102164730.324035-14-vaibhavgupta40@gmail.com> (raw)
In-Reply-To: <20201102164730.324035-1-vaibhavgupta40@gmail.com>

Drivers using new-framework/generic-framework should not handle standard
power management operations. These operations were performed by legacy
framework through PCI helper functions like pci_save/restore_state(),
pci_set_power_state(), etc.

Drivers should not use them now.

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
index f19f3db1ac6d..dfeb86c865d3 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c
@@ -3440,7 +3440,6 @@ static int _suspend_v3_hw(struct device *device)
 	struct hisi_hba *hisi_hba = sha->lldd_ha;
 	struct device *dev = hisi_hba->dev;
 	struct Scsi_Host *shost = hisi_hba->shost;
-	pci_power_t device_state;
 	int rc;
 
 	if (!pdev->pm_cap) {
@@ -3466,12 +3465,7 @@ static int _suspend_v3_hw(struct device *device)
 
 	hisi_sas_init_mem(hisi_hba);
 
-	device_state = pci_choose_state(pdev, PMSG_SUSPEND);
-	dev_warn(dev, "entering operating state [D%d]\n",
-			device_state);
-	pci_save_state(pdev);
-	pci_disable_device(pdev);
-	pci_set_power_state(pdev, device_state);
+	dev_warn(dev, "entering suspend state\n");
 
 	hisi_sas_release_tasks(hisi_hba);
 
@@ -3491,15 +3485,7 @@ static int _resume_v3_hw(struct device *device)
 
 	dev_warn(dev, "resuming from operating state [D%d]\n",
 		 device_state);
-	pci_set_power_state(pdev, PCI_D0);
-	pci_restore_state(pdev);
-	rc = pci_enable_device(pdev);
-	if (rc) {
-		dev_err(dev, "enable device failed during resume (%d)\n", rc);
-		return rc;
-	}
 
-	pci_set_master(pdev);
 	scsi_unblock_requests(shost);
 	clear_bit(HISI_SAS_REJECT_CMD_BIT, &hisi_hba->flags);
 
@@ -3507,7 +3493,6 @@ static int _resume_v3_hw(struct device *device)
 	rc = hw_init_v3_hw(hisi_hba);
 	if (rc) {
 		scsi_remove_host(shost);
-		pci_disable_device(pdev);
 		return rc;
 	}
 	hisi_hba->hw->phys_init(hisi_hba);
-- 
2.28.0


  parent reply	other threads:[~2020-11-02 16:53 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 16:47 [PATCH v4 00/29] scsi: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 01/29] scsi: megaraid_sas: Drop PCI wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 02/29] scsi: megaraid_sas: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 03/29] scsi: megaraid_sas: update function description Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 04/29] scsi: aacraid: Drop pci_enable_wake() from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 05/29] scsi: aacraid: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 06/29] scsi: aic7xxx: " Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 07/29] scsi: aic79xx: " Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 08/29] scsi: arcmsr: Drop PCI wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 09/29] scsi: arcmsr: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 10/29] scsi: esas2r: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 11/29] scsi: esas2r: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 12/29] scsi: hisi_sas_v3_hw: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` Vaibhav Gupta [this message]
2020-11-02 16:47 ` [PATCH v4 14/29] scsi: hisi_sas_v3_hw: Remove extra function calls for runtime pm Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 15/29] scsi: mpt3sas_scsih: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 16/29] scsi: mpt3sas_scsih: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 17/29] scsi: lpfc: " Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 18/29] scsi: pm_8001: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 19/29] scsi: pm_8001: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 20/29] scsi: hpsa: " Vaibhav Gupta
2020-11-04 18:08   ` Don.Brace
2020-11-02 16:47 ` [PATCH v4 21/29] scsi: 3w-9xxx: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 22/29] scsi: 3w-9xxx: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 23/29] scsi: 3w-sas: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 24/29] scsi: 3w-sas: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 25/29] scsi: mvumi: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 26/29] scsi: mvumi: use generic power management Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 27/29] scsi: mvumi: update function description Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 28/29] scsi: pmcraid: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-11-02 16:47 ` [PATCH v4 29/29] scsi: pmcraid: use generic power management Vaibhav Gupta
2020-12-01  5:05 ` [PATCH v4 00/29] scsi: " Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102164730.324035-14-vaibhavgupta40@gmail.com \
    --to=vaibhavgupta40@gmail.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=aacraid@microsemi.com \
    --cc=aradford@gmail.com \
    --cc=balsundar.p@microchip.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn@helgaas.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=don.brace@microsemi.com \
    --cc=esc.storagedev@microsemi.com \
    --cc=hare@suse.com \
    --cc=helgaas@kernel.org \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=john.garry@huawei.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxdrivers@attotech.com \
    --cc=martin.petersen@oracle.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=skhan@linuxfoundation.org \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=vaibhav.varodek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®