From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98137C2D0A3 for ; Mon, 2 Nov 2020 21:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A58C20870 for ; Mon, 2 Nov 2020 21:24:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M0L+uqsF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbgKBVYE (ORCPT ); Mon, 2 Nov 2020 16:24:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27601 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbgKBVYD (ORCPT ); Mon, 2 Nov 2020 16:24:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604352242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5krEaljvyrhzNRqKb50IcCPttqpfwQ2VdU+VnjlUbEw=; b=M0L+uqsFa3JXR8oBrwpsU+NODhRqxIyxJ3FSPiZkD8/mYEgpjEeZHLkIu4kDFUKJ4U1Jfi j0UHussuTJTbGocRcdnO6NUT75Phnis5MXu1fbcwlyMXDvgW1sBUbCqbWqfzXDuv6TDZjW Yx/26AHdZ4Rj07fERFfNx/gIz5YWhNg= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-255-288VSniwN8Cp2XveQBSyXw-1; Mon, 02 Nov 2020 16:24:00 -0500 X-MC-Unique: 288VSniwN8Cp2XveQBSyXw-1 Received: by mail-qt1-f199.google.com with SMTP id 2so8902883qtb.5 for ; Mon, 02 Nov 2020 13:24:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5krEaljvyrhzNRqKb50IcCPttqpfwQ2VdU+VnjlUbEw=; b=uHAGWlPdoG3eGjt4ZBrsjlPeECT8b77CbBXQFFUgfxtK7otMf8uSs2vnxJYXL/AfI0 L8X/2vKA2tf/5Vw1s109PKsC+RHP9+MKogOagaHBn31JAtSIAUIBe0cPPqPz3Sjphr8n fUiV99Yf73TWCqw1tE92O5isSSY6So6VBcrsjIzpRFhTSbJNzCyXf4ogaKe9uqp3xOgL YGxHQECNhoSK+sjsJoC4oG1K6RNYz2/L8tRE0dM8OlbA4J7KfpMO3cbPEGEbnOCgIro5 D8AagqoSQuQV551EDlILUEz0hSv9cbD6SpZ96PVZh/ipuSdM6y86rwMgFXRpWDXvISH1 Hwig== X-Gm-Message-State: AOAM532dy3u3a+vRs55ZEV8sa51R5qIO4UOIi6reVb0o5+YHCgq6n+S0 4mKMKEkIgnW2qwglBapsoH32xyC5mJnN9cDFzxLNw3Gpv9vzHorOB4oJZz5U54aASlv8Qkmv6pC fISVp8rdwspqsyMXxwJqH/a9z X-Received: by 2002:ac8:51cd:: with SMTP id d13mr16561567qtn.148.1604352240472; Mon, 02 Nov 2020 13:24:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzVZNW9d1dBhPMDwDQjUbkTYH74maXUmC/a3NMkduqNhkNQs5W808H/I9luHcDXbPi93/dC1A== X-Received: by 2002:ac8:51cd:: with SMTP id d13mr16561552qtn.148.1604352240251; Mon, 02 Nov 2020 13:24:00 -0800 (PST) Received: from xz-x1 (bras-vprn-toroon474qw-lp130-20-174-93-89-196.dsl.bell.ca. [174.93.89.196]) by smtp.gmail.com with ESMTPSA id 69sm9012776qko.48.2020.11.02.13.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 13:23:59 -0800 (PST) Date: Mon, 2 Nov 2020 16:23:58 -0500 From: Peter Xu To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Andrew Jones , Peter Shier , Sean Christopherson , Thomas Huth , Peter Feiner Subject: Re: [PATCH 1/5] KVM: selftests: Factor code out of demand_paging_test Message-ID: <20201102212358.GB20600@xz-x1> References: <20201027233733.1484855-1-bgardon@google.com> <20201027233733.1484855-2-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201027233733.1484855-2-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 04:37:29PM -0700, Ben Gardon wrote: > Much of the code in demand_paging_test can be reused by other, similar > multi-vCPU-memory-touching-perfromance-tests. Factor that common code > out for reuse. > > No functional change expected. Is there explicit reason to put the common code in a header rather than perf_test_util.c? No strong opinion on this especially this is test code, just curious. Since iiuc .c file is still preferred for things like this. > > This series was tested by running the following invocations on an Intel > Skylake machine: > dirty_log_perf_test -b 20m -i 100 -v 64 > dirty_log_perf_test -b 20g -i 5 -v 4 > dirty_log_perf_test -b 4g -i 5 -v 32 > demand_paging_test -b 20m -v 64 > demand_paging_test -b 20g -v 4 > demand_paging_test -b 4g -v 32 > All behaved as expected. May move this chunk to the cover letter to avoid keeping it in every commit (btw, you mentioned "this series" but I feel like you meant "you verified that after applying each of the commits"). Thanks, -- Peter Xu