From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Pavel Begunkov <asml.silence@gmail.com>,
Jens Axboe <axboe@kernel.dk>, Sasha Levin <sashal@kernel.org>,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org
Subject: [PATCH AUTOSEL 5.8 08/29] io_uring: don't miss setting IO_WQ_WORK_CONCURRENT
Date: Mon, 2 Nov 2020 20:19:07 -0500 [thread overview]
Message-ID: <20201103011928.183145-8-sashal@kernel.org> (raw)
In-Reply-To: <20201103011928.183145-1-sashal@kernel.org>
From: Pavel Begunkov <asml.silence@gmail.com>
[ Upstream commit feaadc4fc2ebdbd53ffed1735077725855a2af53 ]
Set IO_WQ_WORK_CONCURRENT for all REQ_F_FORCE_ASYNC requests, do that in
that is also looks better.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fs/io_uring.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 8e9c58fa76362..d84eb0cc49ee4 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1089,6 +1089,9 @@ static inline void io_prep_async_work(struct io_kiocb *req,
io_req_init_async(req);
+ if (req->flags & REQ_F_FORCE_ASYNC)
+ req->work.flags |= IO_WQ_WORK_CONCURRENT;
+
if (req->flags & REQ_F_ISREG) {
if (def->hash_reg_file)
io_wq_hash_work(&req->work, file_inode(req->file));
@@ -5876,13 +5879,6 @@ static void io_queue_sqe(struct io_kiocb *req, const struct io_uring_sqe *sqe)
if (unlikely(ret < 0))
goto fail_req;
}
-
- /*
- * Never try inline submit of IOSQE_ASYNC is set, go straight
- * to async execution.
- */
- io_req_init_async(req);
- req->work.flags |= IO_WQ_WORK_CONCURRENT;
io_queue_async_work(req);
} else {
__io_queue_sqe(req, sqe);
--
2.27.0
next prev parent reply other threads:[~2020-11-03 1:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 1:19 [PATCH AUTOSEL 5.8 01/29] ARM: dts: sun4i-a10: fix cpu_alert temperature Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 02/29] arm64: dts: meson-axg: add USB nodes Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 03/29] arm64: dts: meson-axg-s400: enable USB OTG Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 04/29] arm64: dts: meson: add missing g12 rng clock Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 05/29] arm64: dts: amlogic: meson-g12: use the G12A specific dwmac compatible Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 06/29] x86/kexec: Use up-to-dated screen_info copy to fill boot params Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 07/29] hyperv_fb: Update screen_info after removing old framebuffer Sasha Levin
2020-11-03 1:19 ` Sasha Levin [this message]
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 09/29] of: Fix reserved-memory overlap detection Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 10/29] ARM: dts: mmp3: Add power domain for the camera Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 11/29] drm/sun4i: frontend: Rework a bit the phase data Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 12/29] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 13/29] drm/sun4i: frontend: Fix the scaler phase on A33 Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 14/29] drm/v3d: Fix double free in v3d_submit_cl_ioctl() Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 15/29] blk-cgroup: Fix memleak on error path Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 16/29] blk-cgroup: Pre-allocate tree node on blkg_conf_prep Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 17/29] btrfs: add a helper to read the tree_root commit root for backref lookup Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 18/29] scsi: core: Don't start concurrent async scan on same host Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 19/29] drm/amdgpu: add DID for navi10 blockchain SKU Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 20/29] scsi: ibmvscsi: Fix potential race after loss of transport Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 21/29] vsock: use ns_capable_noaudit() on socket create Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 22/29] nvme-rdma: handle unexpected nvme completion data length Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 23/29] nvmet: fix a NULL pointer dereference when tracing the flush command Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 24/29] drm/vc4: drv: Add error handding for bind Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 25/29] ACPI: NFIT: Fix comparison to '-ENXIO' Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 26/29] usb: cdns3: gadget: suspicious implicit sign extension Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 27/29] drm/nouveau/nouveau: fix the start/end range for migration Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 28/29] drm/nouveau/gem: fix "refcount_t: underflow; use-after-free" Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 29/29] arm64/smp: Move rcu_cpu_starting() earlier Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103011928.183145-8-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®