From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Hoegeun Kwon <hoegeun.kwon@samsung.com>,
Maxime Ripard <maxime@cerno.tech>,
Sasha Levin <sashal@kernel.org>,
dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 4.19 10/11] drm/vc4: drv: Add error handding for bind
Date: Mon, 2 Nov 2020 20:20:38 -0500 [thread overview]
Message-ID: <20201103012039.183672-10-sashal@kernel.org> (raw)
In-Reply-To: <20201103012039.183672-1-sashal@kernel.org>
From: Hoegeun Kwon <hoegeun.kwon@samsung.com>
[ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ]
There is a problem that if vc4_drm bind fails, a memory leak occurs on
the drm_property_create side. Add error handding for drm_mode_config.
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/vc4/vc4_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 04270a14fcaaf..868dd1ef3b693 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -312,6 +312,7 @@ static int vc4_drm_bind(struct device *dev)
component_unbind_all(dev, drm);
gem_destroy:
vc4_gem_destroy(drm);
+ drm_mode_config_cleanup(drm);
vc4_bo_cache_destroy(drm);
dev_put:
drm_dev_put(drm);
--
2.27.0
next prev parent reply other threads:[~2020-11-03 1:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 1:20 [PATCH AUTOSEL 4.19 01/11] ARM: dts: sun4i-a10: fix cpu_alert temperature Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 02/11] arm64: dts: meson-axg-s400: enable USB OTG Sasha Levin
2020-11-03 8:56 ` Neil Armstrong
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 03/11] x86/kexec: Use up-to-dated screen_info copy to fill boot params Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 04/11] of: Fix reserved-memory overlap detection Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 05/11] blk-cgroup: Fix memleak on error path Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 06/11] blk-cgroup: Pre-allocate tree node on blkg_conf_prep Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 07/11] scsi: core: Don't start concurrent async scan on same host Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 08/11] vsock: use ns_capable_noaudit() on socket create Sasha Levin
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 09/11] nvme-rdma: handle unexpected nvme completion data length Sasha Levin
2020-11-03 1:20 ` Sasha Levin [this message]
2020-11-03 1:20 ` [PATCH AUTOSEL 4.19 11/11] ACPI: NFIT: Fix comparison to '-ENXIO' Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103012039.183672-10-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegeun.kwon@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®