From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A91EC00A89 for ; Tue, 3 Nov 2020 01:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52C282225E for ; Tue, 3 Nov 2020 01:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366576; bh=iyOK1jee0ofzuWK2iruqh5P+w/16VMaZeppQ6bw4obg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0Kuc2BJoH9LGdnRf+Vox+Kqr6xCfK41J+k1e83ekxG2grYukLBAsgzPdHVN9Dxa2M 3+rfOsVqnxjFwgN7UUHJXjjF1mDko+XsLeQp2DEnzmPhbJzQ7CpQQ5bvYY7rkxqLQD AcVOg2B41MuSSIuAzQ+OtuNHVZDf4sppN8aiXW2g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728237AbgKCBUu (ORCPT ); Mon, 2 Nov 2020 20:20:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:35858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728188AbgKCBUr (ORCPT ); Mon, 2 Nov 2020 20:20:47 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FE0B2225E; Tue, 3 Nov 2020 01:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366446; bh=iyOK1jee0ofzuWK2iruqh5P+w/16VMaZeppQ6bw4obg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GpOXik4fZ+mQmIH/onL517syqfE7sFTkP75Byd8ZioCqRpLZHErlZ2aN1kAVATfE4 FTDVhOTioXaqd+h9VievOSXY+FYAPUIoAzOZWdjZB4iG1zIGwbDLpl1Uo92sx4o9NM AgWT4Ov57SCZ87T7LgiGFZPVeJ5mcvWAcvBKjN98= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gabriel Krisman Bertazi , Tejun Heo , Jens Axboe , Sasha Levin , cgroups@vger.kernel.org, linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 05/11] blk-cgroup: Fix memleak on error path Date: Mon, 2 Nov 2020 20:20:33 -0500 Message-Id: <20201103012039.183672-5-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201103012039.183672-1-sashal@kernel.org> References: <20201103012039.183672-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gabriel Krisman Bertazi [ Upstream commit 52abfcbd57eefdd54737fc8c2dc79d8f46d4a3e5 ] If new_blkg allocation raced with blk_policy change and blkg_lookup_check fails, new_blkg is leaked. Acked-by: Tejun Heo Signed-off-by: Gabriel Krisman Bertazi Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- block/blk-cgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index a06547fe6f6b4..51fc803c999d7 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -882,6 +882,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol, blkg = blkg_lookup_check(pos, pol, q); if (IS_ERR(blkg)) { ret = PTR_ERR(blkg); + blkg_free(new_blkg); goto fail_unlock; } -- 2.27.0