From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F056EC388F2 for ; Tue, 3 Nov 2020 01:21:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA78722456 for ; Tue, 3 Nov 2020 01:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366473; bh=+qzEpUJCxxfNzA2GNjkjNiRKONZh93YWfqAcks8ltew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NmDntKoLSEH4OC1iDuuDcLVmMXc5ctDhUTHfufWU8epeHtUBNMPH14l8GLfXDK6kB wsfKei/WbP4J6AUzXJDJaYOj/1LuObMAj34ZnzB5tbdxMTzd/kiaI3VCUQ2UJbzrRj nCoHkxRVNdQ2whxEGYq/u7dy0VnqECuGORyfGPWY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728355AbgKCBVM (ORCPT ); Mon, 2 Nov 2020 20:21:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:36394 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728332AbgKCBVH (ORCPT ); Mon, 2 Nov 2020 20:21:07 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3F962242F; Tue, 3 Nov 2020 01:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366466; bh=+qzEpUJCxxfNzA2GNjkjNiRKONZh93YWfqAcks8ltew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CP2Ne6ftxh0rYcq4SOH+yS1Tyo0js3RBQra8lhaxxrSJjlnBUJ2lybRNb3K7qDnnS PzZqJ8nasXuqqwH133q7W7kKGQcmekpDmUnvTUiTrr51BVxU5ASCGVdtqBulB7xg3h 5tYDrZ/ayW8W5sZKvGgavhV7D3pl6EzWxmbbXFWw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hoegeun Kwon , Maxime Ripard , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.14 09/10] drm/vc4: drv: Add error handding for bind Date: Mon, 2 Nov 2020 20:20:53 -0500 Message-Id: <20201103012054.183811-9-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201103012054.183811-1-sashal@kernel.org> References: <20201103012054.183811-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 1c96edcb302be..028dc2819a368 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -283,6 +283,7 @@ static int vc4_drm_bind(struct device *dev) component_unbind_all(dev, drm); gem_destroy: vc4_gem_destroy(drm); + drm_mode_config_cleanup(drm); vc4_bo_cache_destroy(drm); dev_unref: drm_dev_unref(drm); -- 2.27.0