From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D509AC388F9 for ; Tue, 3 Nov 2020 17:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C23621D91 for ; Tue, 3 Nov 2020 17:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728988AbgKCRiW (ORCPT ); Tue, 3 Nov 2020 12:38:22 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33114 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbgKCRiW (ORCPT ); Tue, 3 Nov 2020 12:38:22 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1ka0G9-0054Fm-Bj; Tue, 03 Nov 2020 18:38:17 +0100 Date: Tue, 3 Nov 2020 18:38:17 +0100 From: Andrew Lunn To: Dan Murphy Cc: Jakub Kicinski , davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com, robh@kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY Message-ID: <20201103173817.GP1042051@lunn.ch> References: <20201030172950.12767-1-dmurphy@ti.com> <20201030172950.12767-5-dmurphy@ti.com> <20201030160330.622c55a7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> <5b32a56b-f054-5790-c5cf-bf1e86403bad@ti.com> <20201103172153.GO1042051@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > > drivers/net/phy/dp83td510.c:70:11: warning: symbol 'dp83td510_feature_array' was not declared. Should it be static? > > > I did not see this warning. Did you use W=1? > > I _think_ that one is W=1. All the PHY drivers are W=1 clean, and i > > want to keep it that way. And i hope to make it the default in a lot > > of the network code soon. > OK I built with the W=1 before submission I did not see this but I will try > some other things. Then it might be sparse. Try C=1. Andrew