Re: [PATCH v11 12/14] s390/vfio-ap: handle host AP config change notification

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4423 bytes --]

Hi Tony,

I love your patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on linus/master v5.10-rc2 next-20201103]
[cannot apply to kvms390/next linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20201023-011543
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/32786ef6d4ba3703d993a8894ea1d763785fd3a4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Tony-Krowiak/s390-vfio-ap-dynamic-configuration-support/20201023-011543
        git checkout 32786ef6d4ba3703d993a8894ea1d763785fd3a4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/s390/crypto/vfio_ap_ops.c:1316:5: warning: no previous prototype for 'vfio_ap_mdev_reset_queue' [-Wmissing-prototypes]
    1316 | int vfio_ap_mdev_reset_queue(unsigned int apid, unsigned int apqi,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/s390/crypto/vfio_ap_ops.c:1568:6: warning: no previous prototype for 'vfio_ap_mdev_hot_unplug_queue' [-Wmissing-prototypes]
    1568 | void vfio_ap_mdev_hot_unplug_queue(struct vfio_ap_queue *q)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/s390/crypto/vfio_ap_ops.c: In function 'vfio_ap_mdev_on_cfg_remove':
   drivers/s390/crypto/vfio_ap_ops.c:1777:7: warning: variable 'unassigned' set but not used [-Wunused-but-set-variable]
    1777 |  bool unassigned = false;
         |       ^~~~~~~~~~
   drivers/s390/crypto/vfio_ap_ops.c: At top level:
   drivers/s390/crypto/vfio_ap_ops.c:1813:6: warning: no previous prototype for 'vfio_ap_mdev_on_cfg_add' [-Wmissing-prototypes]
    1813 | void vfio_ap_mdev_on_cfg_add(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/s390/crypto/vfio_ap_ops.c:11:
   In function 'memcpy',
       inlined from 'vfio_ap_mdev_unassign_apids' at drivers/s390/crypto/vfio_ap_ops.c:1655:3,
       inlined from 'vfio_ap_mdev_on_cfg_remove' at drivers/s390/crypto/vfio_ap_ops.c:1800:8,
       inlined from 'vfio_ap_on_cfg_changed' at drivers/s390/crypto/vfio_ap_ops.c:1836:2:
>> include/linux/string.h:402:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter
     402 |    __read_overflow2();
         |    ^~~~~~~~~~~~~~~~~~

vim +/__read_overflow2 +402 include/linux/string.h

6974f0c4555e285 Daniel Micay  2017-07-12  393  
6974f0c4555e285 Daniel Micay  2017-07-12  394  __FORTIFY_INLINE void *memcpy(void *p, const void *q, __kernel_size_t size)
6974f0c4555e285 Daniel Micay  2017-07-12  395  {
6974f0c4555e285 Daniel Micay  2017-07-12  396  	size_t p_size = __builtin_object_size(p, 0);
6974f0c4555e285 Daniel Micay  2017-07-12  397  	size_t q_size = __builtin_object_size(q, 0);
6974f0c4555e285 Daniel Micay  2017-07-12  398  	if (__builtin_constant_p(size)) {
6974f0c4555e285 Daniel Micay  2017-07-12  399  		if (p_size < size)
6974f0c4555e285 Daniel Micay  2017-07-12  400  			__write_overflow();
6974f0c4555e285 Daniel Micay  2017-07-12  401  		if (q_size < size)
6974f0c4555e285 Daniel Micay  2017-07-12 @402  			__read_overflow2();
6974f0c4555e285 Daniel Micay  2017-07-12  403  	}
6974f0c4555e285 Daniel Micay  2017-07-12  404  	if (p_size < size || q_size < size)
6974f0c4555e285 Daniel Micay  2017-07-12  405  		fortify_panic(__func__);
47227d27e2fcb01 Daniel Axtens 2020-06-03  406  	return __underlying_memcpy(p, q, size);
6974f0c4555e285 Daniel Micay  2017-07-12  407  }
6974f0c4555e285 Daniel Micay  2017-07-12  408  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63158 bytes --]