mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>
Subject: Re: [GIT PULL] Docs-build warning fixes for 5.10-rc3
Date: Tue, 3 Nov 2020 21:24:32 +0000	[thread overview]
Message-ID: <20201103212432.GI27442@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=wghhw0SpqSKKUqt5eum=UfLD3Qa0suoRxLy_cJc4hChug@mail.gmail.com>

On Tue, Nov 03, 2020 at 01:18:27PM -0800, Linus Torvalds wrote:
> On Tue, Nov 3, 2020 at 11:44 AM Jonathan Corbet <corbet@lwn.net> wrote:
> >
> > This pull contains a series of warning fixes from Mauro; once applied, the
> > number of warnings from the once-noisy docs build process is nearly zero.
> > Getting to this point has required a lot of work; once there, hopefully we
> > can keep things that way.
> 
> I wonder if it is quiet enough that we could make new doc build noise
> trigger some kind of linux-next warning?

We can move checkdoc out of W=1 ... something like this?

+++ b/scripts/Makefile.build
@@ -103,9 +103,7 @@ else ifeq ($(KBUILD_CHECKSRC),2)
         cmd_force_checksrc = $(CHECK) $(CHECKFLAGS) $(c_flags) $<
 endif
 
-ifneq ($(KBUILD_EXTRA_WARN),)
-  cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $<
-endif
+cmd_checkdoc = $(srctree)/scripts/kernel-doc -none $<
 
 # Compile C sources (.c)
 # ---------------------------------------------------------------------------

although people might whinge if it increases kernel build time noticably
(I haven't checked if it does).

It won't catch all the things that actually running Sphinx will, but
it catches the common things (forgot to update the docs after changing a
function parameter, for example)

  reply	other threads:[~2020-11-03 21:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 19:44 Jonathan Corbet
2020-11-03 21:18 ` Linus Torvalds
2020-11-03 21:24   ` Matthew Wilcox [this message]
2020-11-04 22:06   ` Stephen Rothwell
2020-11-04 22:40     ` Jonathan Corbet
2020-11-03 21:51 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103212432.GI27442@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®