From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E7BC2D0A3 for ; Wed, 4 Nov 2020 13:23:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6FE3020786 for ; Wed, 4 Nov 2020 13:23:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730027AbgKDNXd (ORCPT ); Wed, 4 Nov 2020 08:23:33 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:34664 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729836AbgKDNXc (ORCPT ); Wed, 4 Nov 2020 08:23:32 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaIl6-005CxM-8o; Wed, 04 Nov 2020 14:23:28 +0100 Date: Wed, 4 Nov 2020 14:23:28 +0100 From: Andrew Lunn To: Lee Jones Cc: davem@davemloft.net, kuba@kernel.org, Woojung Huh , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Microchip Linux Driver Support , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 01/12] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Message-ID: <20201104132328.GX933237@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-2-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201104090610.1446616-2-lee.jones@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 09:05:59AM +0000, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’: > drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’: > drivers/net/usb/lan78xx.c:879:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_deferred_multicast_write’: > drivers/net/usb/lan78xx.c:1041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_update_flowcontrol’: > drivers/net/usb/lan78xx.c:1127:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_init_mac_address’: > drivers/net/usb/lan78xx.c:1666:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_link_status_change’: > drivers/net/usb/lan78xx.c:1841:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_irq_bus_sync_unlock’: > drivers/net/usb/lan78xx.c:1920:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan8835_fixup’: > drivers/net/usb/lan78xx.c:1994:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_rx_max_frame_length’: > drivers/net/usb/lan78xx.c:2192:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_change_mtu’: > drivers/net/usb/lan78xx.c:2270:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_mac_addr’: > drivers/net/usb/lan78xx.c:2299:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_features’: > drivers/net/usb/lan78xx.c:2333:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_suspend’: > drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] > > Cc: Woojung Huh > Cc: Microchip Linux Driver Support > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Andrew Lunn Andrew