mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Michal Hocko <mhocko@suse.com>
Cc: <linux-mm@kvack.org>, Andrew Morton <akpm@linux-foundation.org>,
	Shakeel Butt <shakeelb@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH rfc 1/3] mm: memcg: deprecate the non-hierarchical mode
Date: Wed, 4 Nov 2020 14:56:13 -0800	[thread overview]
Message-ID: <20201104225613.GF1938922@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201104083746.GC10052@dhcp22.suse.cz>

On Wed, Nov 04, 2020 at 09:37:46AM +0100, Michal Hocko wrote:
> On Tue 03-11-20 13:27:23, Roman Gushchin wrote:
> > The non-hierarchical cgroup v1 mode is a legacy of early days
> > of the memory controller and doesn't bring any value today.
> 
> This is a bold statement ;)
> All that we know today is that we have a warning in place to complain
> loudly when somebody relies on use_hierarchy=0 with a deeper
> hierarchy. For all those years we have seen _zero_ reports that would
> describe a sensible usecase.
> Moreover we (SUSE) have backported this warning into old distribution
> kernels (since 3.0 based kernels) to extend the coverage and didn't hear
> even for users who adopt new kernels only very slowly. The only report
> we have seen so far was a LTP test suite which doesn't really reflect
> any real life usecase.

Good to know, thank you for providing this information. I'm also
not aware of any users of the non-hierarchical mode.

> 
> Feel free to reuse the above in the changelog.
> 
> > However, it complicates the code and creates many edge cases
> > all over the memory controller code.
> > 
> > It's a good time to deprecate it completely.
> > 
> > Functionally this patch enabled is by default for all cgroups
> > and forbids switching it off. Nothing changes if cgroup v2 is used:
> > hierarchical mode was enforced from scratch.
> > 
> > To protect the ABI memory.use_hierarchy interface is preserved
> > with a limited functionality: reading always returns "1", writing
> > of "1" passes silently, writing of any other value fails with
> > -EINVAL and a warning to dmesg (on the first occasion).
> 
> Yes, that makes sense.
>  
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> 
> I do not see any problems with the patch or any left overs behind
> (except for the documentation which you handle in the follow up
> patches).
> 
> Acked-by: Michal Hocko <mhocko@suse.com>
> 
> Thanks and let's see whether some last minute usecase show up.

Thank you!

Roman

  reply	other threads:[~2020-11-04 22:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 21:27 [PATCH rfc 0/3] mm: memcg: deprecate cgroup v1 " Roman Gushchin
2020-11-03 21:27 ` [PATCH rfc 1/3] mm: memcg: deprecate the " Roman Gushchin
2020-11-04  8:37   ` Michal Hocko
2020-11-04 22:56     ` Roman Gushchin [this message]
2020-11-04 14:58   ` Shakeel Butt
2020-11-03 21:27 ` [PATCH rfc 2/3] docs: cgroup-v1: reflect the deprecation of " Roman Gushchin
2020-11-04  8:39   ` Michal Hocko
2020-11-04 15:00   ` Shakeel Butt
2020-11-03 21:27 ` [PATCH rfc 3/3] cgroup: remove obsoleted broken_hierarchy and warned_broken_hierarchy Roman Gushchin
2020-11-04 15:01   ` Shakeel Butt
2020-11-04 23:10 ` [PATCH rfc 0/3] mm: memcg: deprecate cgroup v1 non-hierarchical mode David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104225613.GF1938922@carbon.dhcp.thefacebook.com \
    --to=guro@fb.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=shakeelb@google.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®