From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C653CC2D0A3 for ; Thu, 5 Nov 2020 03:10:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65FB120825 for ; Thu, 5 Nov 2020 03:10:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388495AbgKEDKg (ORCPT ); Wed, 4 Nov 2020 22:10:36 -0500 Received: from mga07.intel.com ([134.134.136.100]:32196 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731175AbgKEDKf (ORCPT ); Wed, 4 Nov 2020 22:10:35 -0500 IronPort-SDR: 0NXL0gcFcheiarqnu58mvD03D352BgQl3DkW1roAEKquaYHhNHtpLHii31I4Zz28tLxybnzTrB lNepqaL3BbpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="233480532" X-IronPort-AV: E=Sophos;i="5.77,452,1596524400"; d="scan'208";a="233480532" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 19:10:35 -0800 IronPort-SDR: 5dmCqo1BSQtpGjxLQCtGG7vH92Y0IBfZXaSsmb1vuvHbOEC+X3IUHZG12SGwHiYriROQF/NvgC 0zK8BGcvoYQQ== X-IronPort-AV: E=Sophos;i="5.77,452,1596524400"; d="scan'208";a="539191049" Received: from shuo-intel.sh.intel.com (HELO localhost) ([10.239.154.30]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 19:10:32 -0800 Date: Thu, 5 Nov 2020 11:10:29 +0800 From: Shuo A Liu To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Sean Christopherson , Yu Wang , Reinette Chatre , Zhi Wang , Zhenyu Wang Subject: Re: [PATCH v5 06/17] virt: acrn: Introduce VM management interfaces Message-ID: <20201105031029.GB17702@shuo-intel.sh.intel.com> References: <20201019061803.13298-1-shuo.a.liu@intel.com> <20201019061803.13298-7-shuo.a.liu@intel.com> <20201104190235.GA2855400@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20201104190235.GA2855400@kroah.com> User-Agent: Mutt/1.8.3 (2017-05-23) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 4.Nov'20 at 20:02:35 +0100, Greg Kroah-Hartman wrote: >On Mon, Oct 19, 2020 at 02:17:52PM +0800, shuo.a.liu@intel.com wrote: >> --- /dev/null >> +++ b/include/uapi/linux/acrn.h >> @@ -0,0 +1,56 @@ >> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ >> +/* >> + * Userspace interface for /dev/acrn_hsm - ACRN Hypervisor Service Module >> + * >> + * This file can be used by applications that need to communicate with the HSM >> + * via the ioctl interface. >> + */ >> + >> +#ifndef _UAPI_ACRN_H >> +#define _UAPI_ACRN_H >> + >> +#include >> + >> +/** >> + * struct acrn_vm_creation - Info to create a User VM >> + * @vmid: User VM ID returned from the hypervisor >> + * @reserved0: Reserved >> + * @vcpu_num: Number of vCPU in the VM. Return from hypervisor. >> + * @reserved1: Reserved >> + * @uuid: UUID of the VM. Pass to hypervisor directly. >> + * @vm_flag: Flag of the VM creating. Pass to hypervisor directly. >> + * @ioreq_buf: Service VM GPA of I/O request buffer. Pass to >> + * hypervisor directly. >> + * @cpu_affinity: CPU affinity of the VM. Pass to hypervisor directly. >> + * @reserved2: Reserved > >Reserved and must be 0? Not a must. >What are they reserved for? > >Same for all of the reserved fields, why? Some reserved fields are to map layout in the hypervisor side, others are for future use. > >> + */ >> +struct acrn_vm_creation { >> + __u16 vmid; >> + __u16 reserved0; >> + __u16 vcpu_num; >> + __u16 reserved1; >> + __u8 uuid[16]; > >We have a userspace-visable uid structure in include/uapi/uuid.h, why >not use that? we just pass the uuid data from user space to hypervisor. So, we can remove a header dependeny with using raw data format. Thanks shuo