From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Suleiman Souhlal <suleiman@google.com>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/virtio: use kvmalloc for large allocations
Date: Thu, 5 Nov 2020 16:00:54 +0900 [thread overview]
Message-ID: <20201105070054.GD128655@google.com> (raw)
In-Reply-To: <20201105065233.3td3zuyfmbypjtvq@sirius.home.kraxel.org>
Hi,
On (20/11/05 07:52), Gerd Hoffmann wrote:
> > - *ents = kmalloc_array(*nents, sizeof(struct virtio_gpu_mem_entry),
> > - GFP_KERNEL);
> > + *ents = kvmalloc_array(*nents,
> > + sizeof(struct virtio_gpu_mem_entry),
> > + GFP_KERNEL);
>
> Shouldn't that be balanced with a kvfree() elsewhere?
I think it already is. ents pointer is assigned to vbuf->data_buf,
and free_vbuf() already uses kvfree(vbuf->data_buf) to free it.
-ss
next prev parent reply other threads:[~2020-11-05 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 1:47 Sergey Senozhatsky
2020-11-05 6:52 ` Gerd Hoffmann
2020-11-05 7:00 ` Sergey Senozhatsky [this message]
2020-11-05 11:34 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105070054.GD128655@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=suleiman@google.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®