From: Dongdong Tao <tdd21151186@gmail.com>
To: colyli@suse.de
Cc: dongdong.tao@canonical.com,
Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org (open list:BCACHE (BLOCK LAYER
CACHE)), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] bcache: make writeback_cutoff and writeback_cutoff_sync writeable
Date: Thu, 5 Nov 2020 22:19:39 +0800 [thread overview]
Message-ID: <20201105141939.9223-1-tdd21151186@gmail.com> (raw)
From: dongdong tao <dongdong.tao@canonical.com>
commit 9aaf51654672 ("bcache: make cutoff_writeback and
cutoff_writeback_sync tunable") intend to make these two option
configurable by user, but these two are still read-only.
Signed-off-by: dongdong tao <dongdong.tao@canonical.com>
---
drivers/md/bcache/sysfs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 554e3afc9b68..81f4a681705c 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -102,8 +102,8 @@ read_attribute(writeback_keys_done);
read_attribute(writeback_keys_failed);
read_attribute(io_errors);
read_attribute(congested);
-read_attribute(cutoff_writeback);
-read_attribute(cutoff_writeback_sync);
+rw_attribute(cutoff_writeback);
+rw_attribute(cutoff_writeback_sync);
rw_attribute(congested_read_threshold_us);
rw_attribute(congested_write_threshold_us);
@@ -902,6 +902,8 @@ STORE(__bch_cache_set)
sysfs_strtoul_bool(copy_gc_enabled, c->copy_gc_enabled);
sysfs_strtoul_bool(idle_max_writeback_rate,
c->idle_max_writeback_rate_enabled);
+ sysfs_strtoul_clamp(cutoff_writeback, bch_cutoff_writeback, 1, 100);
+ sysfs_strtoul_clamp(cutoff_writeback_sync, bch_cutoff_writeback_sync, 1, 100);
/*
* write gc_after_writeback here may overwrite an already set
--
2.17.1
next reply other threads:[~2020-11-05 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:19 Dongdong Tao [this message]
2020-11-05 14:23 ` Coly Li
2020-11-05 14:35 ` 陶冬冬
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105141939.9223-1-tdd21151186@gmail.com \
--to=tdd21151186@gmail.com \
--cc=colyli@suse.de \
--cc=dongdong.tao@canonical.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®