From: Maxime Ripard <maxime@cerno.tech>
To: Yu-Tung Chang <mtwget@gmail.com>
Cc: robh+dt@kernel.org, wens@csie.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] ARM: dts: sun8i: h3: Add initial NanoPi R1 support
Date: Thu, 5 Nov 2020 18:10:51 +0100 [thread overview]
Message-ID: <20201105171051.ducvxcdj5jfarmgn@gilmour.lan> (raw)
In-Reply-To: <CAHRgzyOao=w6Yyqqvi1Z26=rfJgumkzDbWLxD+_5uaLmyAWiQA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Wed, Nov 04, 2020 at 04:07:48PM +0800, Yu-Tung Chang wrote:
> > > +&uart1 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&uart1_pins>;
> >
> > This should be already set in the DTSI
> >
> uart0 as the debugging interface, uart1 as the external uart port,
> uart3 as the bluetooth.
What I mean is that since it's the only muxing option, the pinctrl
properties should already be set in the DTSI, so it's redundant to put
them in the DTS.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-11-05 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 10:01 [PATCH v1 0/1] " Yu-Tung Chang
2020-11-02 10:01 ` [PATCH v1 1/1] " Yu-Tung Chang
2020-11-03 11:37 ` Maxime Ripard
2020-11-04 8:07 ` Yu-Tung Chang
2020-11-05 17:10 ` Maxime Ripard [this message]
2020-11-06 2:03 ` Yu-Tung Chang
2020-11-06 2:10 ` Chen-Yu Tsai
2020-11-06 11:25 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105171051.ducvxcdj5jfarmgn@gilmour.lan \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtwget@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®