From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=d/j+=EM=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6F202C388F2
	for <linux-kernel@archiver.kernel.org>; Fri,  6 Nov 2020 09:07:47 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0F57920B80
	for <linux-kernel@archiver.kernel.org>; Fri,  6 Nov 2020 09:07:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1604653667;
	bh=/WyFgfLiGBaivhLHjIz34mnY1A6swv5xaVPIuWmwMgU=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=kzGjoNQmPrPYYXud1XdGpUor0ScuVHbYUFM3h4Am/ZlOI1e5Q+PkRTlWsyRr9yTUz
	 nI+FVrlfWPw3e1qXwHJTvi/QvgAQvFoH/yi9EiXxCg5zJCX4b+SGj1lmLHdVmK22mD
	 pvQwpRva9Ztg9I1wTIFjIzhLYlPB0ZsCoyaI7J/U=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726489AbgKFJHq (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 6 Nov 2020 04:07:46 -0500
Received: from mail.kernel.org ([198.145.29.99]:45260 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725924AbgKFJHp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Nov 2020 04:07:45 -0500
Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id F177A20936;
        Fri,  6 Nov 2020 09:07:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1604653663;
        bh=/WyFgfLiGBaivhLHjIz34mnY1A6swv5xaVPIuWmwMgU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=WnOhTeDRPNs0Thwdi2AySf3T1uexugRszfvWjTL6d9s7t8NaLOaMvcWnq9sQYeJUc
         GbacubcrP0u+B7mW9YZ5SSiBCSKuabvXr3h71sH3dJLaHkvvV+JpmBESXmXrb5rVte
         /PVOJcyd5irAOomsEe/Wr/aFsSvgpxQ1Brbh0h18=
Date:   Fri, 6 Nov 2020 09:07:38 +0000
From:   Will Deacon <will@kernel.org>
To:     tangyouling <tangyouling@loongson.cn>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, ardb@kernel.org
Subject: Re: [PATCH] arm64: Change the location of DISCARDS
Message-ID: <20201106090737.GA9496@willie-the-truck>
References: <1604486932-18889-1-git-send-email-tangyouling@loongson.cn>
 <20201105214738.GB8600@willie-the-truck>
 <759a51ad-8b2e-24bd-52f5-99769ff5557c@loongson.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <759a51ad-8b2e-24bd-52f5-99769ff5557c@loongson.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 06, 2020 at 09:06:42AM +0800, tangyouling wrote:
> In the include/asm-generic/vmlinux.lds.h:978, the description is as follows:
> DISCARDS must be the last of output section definitions so that such archs
> put those in earlier section definitions.

Sure, I see that text, but I don't get why it matters. It would be nice to
have some rationale as to what could go wrong if they aren't at the end,
so we can improve that comment and avoid the inevitable regression in the
future when things get shuffled around.

Will