From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA8DC2D0A3 for ; Fri, 6 Nov 2020 10:53:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1E9821707 for ; Fri, 6 Nov 2020 10:53:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbgKFKx6 (ORCPT ); Fri, 6 Nov 2020 05:53:58 -0500 Received: from elvis.franken.de ([193.175.24.41]:41177 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbgKFKx4 (ORCPT ); Fri, 6 Nov 2020 05:53:56 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kazNR-0000vt-01; Fri, 06 Nov 2020 11:53:53 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id D7E1DC4DDA; Fri, 6 Nov 2020 11:49:33 +0100 (CET) Date: Fri, 6 Nov 2020 11:49:33 +0100 From: Thomas Bogendoerfer To: Qinglang Miao Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mips: ar7: add missing iounmap() on error in ar7_gpio_init Message-ID: <20201106104933.GC9806@alpha.franken.de> References: <20201028091545.136212-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028091545.136212-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2020 at 05:15:45PM +0800, Qinglang Miao wrote: > Add the missing iounmap() of gpch->regs before return from > ar7_gpio_init() in the error handling case. > > Signed-off-by: Qinglang Miao > --- > arch/mips/ar7/gpio.c | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]