From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17013C2D0A3 for ; Fri, 6 Nov 2020 15:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E7AF22227 for ; Fri, 6 Nov 2020 15:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604675380; bh=s/FYo72I6lt9+QYesQbFcIAoPzgpDRs/37yRXdQqM5k=; h=From:To:Cc:Subject:Date:List-ID:From; b=Yu6VyFc47gkfXX9FQoGFgzAq7q3ezzwUmg8x+NbpQ1HM7oQVNAm+oz2MMaoHsbV8S 9fmBiG2vYuM2m+Cj7qCd+4NOjJS8Ij8OfSHm+gNbh9726j4yQVOSM+6LHeCIKcLSHK eV7vfPVfRwE1JE1T6x8jGEW2Is6jjPztJ16XMUDU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727313AbgKFPJj (ORCPT ); Fri, 6 Nov 2020 10:09:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:45236 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgKFPJh (ORCPT ); Fri, 6 Nov 2020 10:09:37 -0500 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 590DF22227; Fri, 6 Nov 2020 15:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604675376; bh=s/FYo72I6lt9+QYesQbFcIAoPzgpDRs/37yRXdQqM5k=; h=From:To:Cc:Subject:Date:From; b=niY8WqBV/LQP5/Zv6YXKlYmfDYoKB+adBBoqmX19s/VeJv9+OlmHmVH7t43qQIkq0 cZ47uoBSseKF7a6ZT9EF/MbPgsOYZ15XgLFVz1zcxlxrtwuJ9uXjcjIqnMYkMYJ3yh zIEr1PwU2DX7lEktrKS9ejhSXnyyvXq0O8CjSY3c= From: Mark Brown To: Greg Kroah-Hartman , "Rafael J . Wysocki" Cc: Daniel Mentz , Saravana Kannan , linux-kernel@vger.kernel.org, Mark Brown Subject: [PATCH RFC] driver core: Ensure DT devices always have fwnode set Date: Fri, 6 Nov 2020 15:07:47 +0000 Message-Id: <20201106150747.31273-1-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently the fwnode API and things that rely on it like fw_devlink will not reliably work for devices created from DT since each subsystem that creates devices must individually set dev->fwnode in addition to setting dev->of_node, currently a number of subsystems don't do so. Ensure that this can't get missed by setting fwnode from of_node if it's not previously been set by the subsystem. Reported-by: Saravana Kannan Signed-off-by: Mark Brown --- *Very* minimally tested. drivers/base/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index d661ada1518f..658626bafd76 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2864,6 +2864,10 @@ int device_add(struct device *dev) if (parent && (dev_to_node(dev) == NUMA_NO_NODE)) set_dev_node(dev, dev_to_node(parent)); + /* ensure that fwnode is set up */ + if (IS_ENABLED(CONFIG_OF) && dev->of_node && !dev->fwnode) + dev->fwnode = of_fwnode_handle(dev->of_node); + /* first, register with generic layer. */ /* we require the name to be set before, and pass NULL */ error = kobject_add(&dev->kobj, dev->kobj.parent, NULL); -- 2.20.1