From: Fenghua Yu <fenghua.yu@intel.com>
To: Xiaoyao Li <xiaoyao.li@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
Tony Luck <tony.luck@intel.com>,
Christopherson Sean J <sean.j.christopherson@intel.com>,
Ashok Raj <ashok.raj@intel.com>,
Ravi V Shankar <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH RFC v3 2/4] x86/bus_lock: Handle warn and fatal in #DB for bus lock
Date: Fri, 6 Nov 2020 20:31:49 +0000 [thread overview]
Message-ID: <20201106203149.GA4097366@otcwcpicx6.sc.intel.com> (raw)
In-Reply-To: <21d0415c-9af4-db18-8e65-410f6ab5ec68@linux.intel.com>
Hi, Xiaoyao,
On Tue, Nov 03, 2020 at 08:15:27PM +0800, Xiaoyao Li wrote:
> On 10/31/2020 8:27 AM, Fenghua Yu wrote:
> > diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
> > index 3c70fb34028b..1c3442000972 100644
> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -953,6 +953,13 @@ static __always_inline void exc_debug_user(struct pt_regs *regs,
> > goto out_irq;
> > }
> > + /*
> > + * Handle bus lock. #DB for bus lock can only be triggered from
> > + * userspace.
> > + */
> > + if (!(dr6 & DR_BUS_LOCK))
>
> it should be
>
> if (dr6 & DR_BUS_LOCK)
>
> since you keep DR6.[bit 11] reserved in this version. bit 11 of
> debug_read_clear_dr6() being set to 1 means bus lock detected.
You are right. Will fix it in the next version.
Thank you very much!
-Fenghua
next prev parent reply other threads:[~2020-11-06 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 0:27 [PATCH RFC v3 0/4] x86/bus_lock: Enable bus lock detection Fenghua Yu
2020-10-31 0:27 ` [PATCH RFC v3 1/4] x86/cpufeatures: Enumerate #DB for " Fenghua Yu
2020-10-31 0:27 ` [PATCH RFC v3 2/4] x86/bus_lock: Handle warn and fatal in #DB for bus lock Fenghua Yu
2020-11-03 12:15 ` Xiaoyao Li
2020-11-06 20:31 ` Fenghua Yu [this message]
2020-10-31 0:27 ` [PATCH RFC v3 3/4] x86/bus_lock: Set rate limit " Fenghua Yu
2020-10-31 0:27 ` [PATCH RFC v3 4/4] Documentation/admin-guide: Change doc for split_lock_detect parameter Fenghua Yu
2020-10-31 3:14 ` Randy Dunlap
2020-11-02 17:03 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106203149.GA4097366@otcwcpicx6.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=rdunlap@infradead.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®