From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A785C2D0A3 for ; Fri, 6 Nov 2020 20:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1E8720B80 for ; Fri, 6 Nov 2020 20:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I4Rhnakv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728531AbgKFUz6 (ORCPT ); Fri, 6 Nov 2020 15:55:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728408AbgKFUz6 (ORCPT ); Fri, 6 Nov 2020 15:55:58 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23EB9C0613CF for ; Fri, 6 Nov 2020 12:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BQCsdYcW7P+jix+PsOpY98zMadVYG0lOPq2m1W8EA9k=; b=I4RhnakvykgPcPZdI9SG8stW6Y 4nVxEtR2UM2tmUrdSbk8fNEFI40T0Rr/G3haSzG+nidLXTDs/+6IuGqtVSTK0EJrNfdrUp7KTrCLS 5RE0H6weuIzsNN2D+3+NrcMbYLAuz9EGCqgIowSlsXDBQtY+DkTDsW45S8fSSVKyLRzZRIM9YRjAs esBG+LnIJ6VQzgqikoB2IDVssiGmsD3bLEGrGNEqtMvtZyiJtk9HiBMNzwn9Q1w/MzM3QGpFlhqqf 47s45NUXlSkY6DjN3iuolYnlAP4hz5R+b2AdeohtMEmXDbPj2Qzqikz/P+gtLaGd2Awz0FSmzt0O2 pRzoNl8g==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb8lk-0001hG-Aa; Fri, 06 Nov 2020 20:55:36 +0000 Date: Fri, 6 Nov 2020 20:55:36 +0000 From: Matthew Wilcox To: Rong Chen Cc: Linus Torvalds , Andrew Morton , Johannes Weiner , Alexey Dobriyan , Chris Wilson , Huang Ying , Hugh Dickins , Jani Nikula , Matthew Auld , William Kucharski , Qian Cai , LKML , lkp@lists.01.org, lkp@intel.com, feng.tang@intel.com, zhengjun.xing@intel.com Subject: Re: [mm] e6e88712e4: stress-ng.tmpfs.ops_per_sec -69.7% regression Message-ID: <20201106205536.GS17076@casper.infradead.org> References: <20201030071715.GV31092@shao2-debian> <20201030131711.GJ27442@casper.infradead.org> <20201030145835.GL27442@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2020 at 01:21:39PM +0800, Rong Chen wrote: > we compared the tmpfs.ops_per_sec: (363 / 103.02) between this commit and > parent commit. Thanks! I see about a 50% hit on my system, and this patch restores the performance. Can you verify this works for you? diff --git a/mm/madvise.c b/mm/madvise.c index 9b065d412e5f..e602333f8c0d 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -225,7 +225,7 @@ static void force_shm_swapin_readahead(struct vm_area_struct *vma, struct address_space *mapping) { XA_STATE(xas, &mapping->i_pages, linear_page_index(vma, start)); - pgoff_t end_index = end / PAGE_SIZE; + pgoff_t end_index = linear_page_index(vma, end + PAGE_SIZE - 1); struct page *page; rcu_read_lock();