From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4E0C388F7 for ; Sat, 7 Nov 2020 05:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 030A9208C7 for ; Sat, 7 Nov 2020 05:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604725733; bh=55KoHb8qRGofoRpTcqTP6+Sj4wA/iZddMk3945/FVcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rG/i2XXqNAAtA3L1kGIEUOB/y8CbAnvGkOxAL4VUbzPe3aPmaFJVTRVeXpq2QNeZA sZa6e6RxQUIOh9pGzxe5fOKMYEF6tagqz/jAwFCa+qQ9bLOL2FpkEBE8z91OmJdpN9 PrZN7vqZHTius9rvEmfDTyxgAD5jTkd8WogeWBPM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727612AbgKGFIu (ORCPT ); Sat, 7 Nov 2020 00:08:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:59010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726880AbgKGFIt (ORCPT ); Sat, 7 Nov 2020 00:08:49 -0500 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BF4C20872; Sat, 7 Nov 2020 05:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604725727; bh=55KoHb8qRGofoRpTcqTP6+Sj4wA/iZddMk3945/FVcc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=clH9jKll51JXfmaZOHedvXOzyp7t2WgbUCWUJcFUbBilgShWQhDpvNoMEYLV6qd43 +Fl/JEjNDA8ao703NxINPTq7DhZShDMQQ3SqcctGfKdjL2V0jw0fCkDbxitCqY1TJo ueNrSwM6MnUGAptjcct12z9Zzj6EsXyQ2pksLgGM= Date: Fri, 6 Nov 2020 21:08:45 -0800 From: Andrew Morton To: Vineet Gupta Cc: Alexey Dobriyan , Ingo Molnar , Alexey Gladkov , Peter Zijlstra , Kees Cook , "Eric W . Biederman" , Vlastimil Babka , Michel Lespinasse , Andrei Vagin , Bernd Edlinger , John Johansen , Oleg Nesterov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-snps-arc@lists.infradead.org Subject: Re: [RFC] proc: get_wchan() stack unwind only makes sense for sleeping/non-self tasks Message-Id: <20201106210845.e9e95e91b779a01b6751e240@linux-foundation.org> In-Reply-To: <20201105231132.2130132-1-vgupta@synopsys.com> References: <20201105231132.2130132-1-vgupta@synopsys.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Nov 2020 15:11:32 -0800 Vineet Gupta wrote: > Most architectures currently check this in their get_wchan() implementation > (ARC doesn't hence this patch). However doing this in core code shows > the semantics better so move the check one level up (eventually remove > the boiler-plate code from arches) It would be nice to clean up the arch callees in the same patch, at least so it doesn't get forgotten about. Are you prepared to propose such a change?