From: Richard Cochran <richardcochran@gmail.com>
To: Wang Qing <wangqing@vivo.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pcp_clock: return EOPNOTSUPP if !CONFIG_PTP_1588_CLOCK
Date: Sat, 7 Nov 2020 06:56:46 -0800 [thread overview]
Message-ID: <20201107145646.GA9653@hoboy.vegasvil.org> (raw)
In-Reply-To: <1604719703-31930-1-git-send-email-wangqing@vivo.com>
On Sat, Nov 07, 2020 at 11:28:23AM +0800, Wang Qing wrote:
> pcp_clock_register() is checked with IS_ERR(), and will crash if !PTP,
> change return value to ERR_PTR(-EOPNOTSUPP) for the !CONFIG_PTP_1588_CLOCK
> and so question resolved.
NAK.
Drivers must use the documented interface.
Thanks,
Richard
prev parent reply other threads:[~2020-11-07 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 3:28 Wang Qing
2020-11-07 14:56 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107145646.GA9653@hoboy.vegasvil.org \
--to=richardcochran@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®