From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0842EC2D0A3 for ; Mon, 9 Nov 2020 17:01:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5E2B20809 for ; Mon, 9 Nov 2020 17:01:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730825AbgKIRBK (ORCPT ); Mon, 9 Nov 2020 12:01:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:58542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730513AbgKIRBK (ORCPT ); Mon, 9 Nov 2020 12:01:10 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9BED20789; Mon, 9 Nov 2020 17:01:08 +0000 (UTC) Date: Mon, 9 Nov 2020 12:01:06 -0500 From: Steven Rostedt To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, linux-rt-users , Thomas Gleixner , Carsten Emde , John Kacur , Daniel Wagner , Tom Zanussi , "Srivatsa S. Bhat" Subject: Re: [PATCH RT 2/6] tcp: Remove superfluous BH-disable around listening_hash Message-ID: <20201109120106.4fe828b4@oasis.local.home> In-Reply-To: <20201109092231.3t2pawkvv7dxasfs@linutronix.de> References: <20201107020636.598338441@goodmis.org> <20201107020727.806739147@goodmis.org> <20201109092231.3t2pawkvv7dxasfs@linutronix.de> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Nov 2020 10:22:31 +0100 Sebastian Andrzej Siewior wrote: > On 2020-11-06 21:06:38 [-0500], Steven Rostedt wrote: > > 5.4.74-rt42-rc1 stable review patch. > > If anyone has any objections, please let me know. > > Please drop that one. Lockep complains on RT with newer softirq code. > Older RT and mainline does not complain here unless it observes > inet_listen_hashbucket::lock in serving-softirq context (which is not > the case). > Note, I took this because it mentioned: "Commit 9652dc2eb9e40 ("tcp: relax listening_hash operations") removed the need to disable bottom half while acquiring listening_hash.lock. There are still two callers left which disable bottom half before the lock is acquired." And that commit was added in 4.10. I will remove it and release a rc2. Thanks! -- Steve