From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECA43C388F7 for ; Tue, 10 Nov 2020 08:29:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E8F320870 for ; Tue, 10 Nov 2020 08:29:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ExwHlle+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728636AbgKJI3L (ORCPT ); Tue, 10 Nov 2020 03:29:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbgKJI3K (ORCPT ); Tue, 10 Nov 2020 03:29:10 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B579C0613CF for ; Tue, 10 Nov 2020 00:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MTClELRHKyU2TjgtYpv32+wHm9fs7/69FtLMOSW87OI=; b=ExwHlle+8ryYuDlhYtI8il6gZA W5sf/VIy3hA6RqG9cPxd0vMYKUb2uZWMRKyPwu5/QnZaNFAIhPCXi8aide0yTdMLQlZBtZJFdlFlo t8LokaOBXe2RP6FrDpFSBL93Fe1hb2YQKWE+SQpZn1woeDjrHHCc6VC3drWOMU+B2RzBNVAB37VEs KsEF6lM7nZxVOLdlMtHRCsA1VfJZVhURpVyXtKEQkdXJy5rAblCdrVIbtc78SJoxETmN6YJ5JT9Eh 25MmG52WBaLkXVFUFgYVx41GyXXGZtaYAx2SwWsU1WlJE96JbMWw9d40nzkpsO0LedfX+ktLZOan/ oJcR/bPQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcP1M-0005IP-IQ; Tue, 10 Nov 2020 08:28:56 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 3C2CE300455; Tue, 10 Nov 2020 09:28:52 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 04DD72B81AABD; Tue, 10 Nov 2020 09:28:51 +0100 (CET) Date: Tue, 10 Nov 2020 09:28:51 +0100 From: Peter Zijlstra To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Song Liu , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 03/24] perf: Add build id data in mmap2 event Message-ID: <20201110082851.GV2594@hirez.programming.kicks-ass.net> References: <20201109215415.400153-1-jolsa@kernel.org> <20201109215415.400153-4-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109215415.400153-4-jolsa@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 10:53:54PM +0100, Jiri Olsa wrote: > There's new misc bit for mmap2 to signal there's build > id data in it: > > #define PERF_RECORD_MISC_BUILD_ID (1 << 14) PERF_RECORD_MISC_MMAP_BUILD_ID would be consistent with the existing PERF_RECORD_MISC_MMAP_DATA naming. Also, AFAICT there's still a bunch of unused bits in misc. 012 CDEF |||---------|||| Where: 0-2 CPUMODE_MASK C PROC_MAP_PARSE_TIMEOUT D MMAP_DATA / COMM_EXEC / FORK_EXEC / SWITCH_OUT E EXACT_IP / SCHED_OUT_PREEMPT F (reserved) Maybe we should put in a comment to keep track of the hole ? Also, perhaps it is time to use F to indicate that @size is in 8 instead of 1 ? That would increase our max entry size to 512K, people seem to hit his 64K limit (insane as it is).