From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE48C388F7 for ; Tue, 10 Nov 2020 15:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A151E207BB for ; Tue, 10 Nov 2020 15:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731562AbgKJPHD (ORCPT ); Tue, 10 Nov 2020 10:07:03 -0500 Received: from mga18.intel.com ([134.134.136.126]:4059 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730200AbgKJPHD (ORCPT ); Tue, 10 Nov 2020 10:07:03 -0500 IronPort-SDR: JuUwofRJdp2tMWMmLJOmobUQQDEPmBU5XNwChhiRfE2Ju8NUD/qD2yR2REDyRF6zVsiO5fxYGi 6k8oDWSmt0/w== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="157766396" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="157766396" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 07:06:48 -0800 IronPort-SDR: I+0IXTGtkR1+xohygxGDWZsVXi9d3EJBaRwYuCNV+pt59xhkB5JDhXNq++hvGubxCXr46vhaRl Jz/rGkyCXWOw== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="322893785" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 07:06:45 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kcVFL-005VRE-Nx; Tue, 10 Nov 2020 17:07:47 +0200 Date: Tue, 10 Nov 2020 17:07:47 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jan Kiszka , David Laight , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v4 0/7] gpio: exar: refactor the driver Message-ID: <20201110150747.GX4077@smile.fi.intel.com> References: <20201110145552.23024-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110145552.23024-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 03:55:45PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > I just wanted to convert the driver to using simpler IDA API but ended up > quickly converting it to using regmap. Unfortunately I don't have the HW > to test it so marking the patches that introduce functional change as RFT > and Cc'ing the original author. Thanks. With reverted reg_width change Reviewed-by: Andy Shevchenko > v1 -> v2: > - add new regmap helper: regmap_assign_bits() > - fix lvl vs sel register access > - set value in direction_output callback > > v2 -> v3: > - drop the regmap helper from series > > v3 -> v4: > - renamed the regmap variable to 'regmap' as leaving the old name caused me > to miss an assignment leading to a crash (culprit spotted by Andy Shevchenko) > > Bartosz Golaszewski (7): > gpio: exar: add a newline after the copyright notice > gpio: exar: include idr.h > gpio: exar: switch to a simpler IDA interface > gpio: exar: use a helper variable for &pdev->dev > gpio: exar: unduplicate address and offset computation > gpio: exar: switch to using regmap > gpio: exar: use devm action for freeing the IDA and drop remove() > > drivers/gpio/Kconfig | 1 + > drivers/gpio/gpio-exar.c | 155 +++++++++++++++++++-------------------- > 2 files changed, 77 insertions(+), 79 deletions(-) > > -- > 2.29.1 > -- With Best Regards, Andy Shevchenko