From: Andrew Lunn <andrew@lunn.ch>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Frederic LAMBERT <frdrc66@gmail.com>,
Gabor Juhos <juhosg@openwrt.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH net v2] net: phy: spi_ks8995: Do not overwrite SPI mode flags
Date: Tue, 10 Nov 2020 23:53:34 +0100 [thread overview]
Message-ID: <20201110225334.GN1456319@lunn.ch> (raw)
In-Reply-To: <CAGngYiV6i=fsySH35UgL2fKiNp1VAfdkJ=hrZ8nmMn_1fkaa-Q@mail.gmail.com>
On Tue, Nov 10, 2020 at 12:06:37PM -0500, Sven Van Asbroeck wrote:
> PING Jakub
>
> On Tue, Nov 10, 2020 at 11:30 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > I see that this is a fix for backporing, but maybe you can send a
> > patches on top of this to:
> > 1) introduce
> > #define SPI_MODE_MASK (SPI_CPHA | SPI_CPOL)
> > spi->mode &= ~SPI_MODE_MASK;
> > > + spi->mode |= SPI_MODE_0;
> >
> Jakub,
>
> Is it possible to merge Andy's suggestion into net?
> Or should this go into net-next?
I would keep with the minimal fix for the moment, it keeps the
dependencies simple.
When you add a helper, it should really be somewhere in the SPI code,
not the net code. So we need both the SPI and the net maintainers to
cooperate to get the helper merged, and then this driver using the
helper.
Andrew
next prev parent reply other threads:[~2020-11-10 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 14:20 Sven Van Asbroeck
2020-11-10 16:31 ` Andy Shevchenko
2020-11-10 16:50 ` Sven Van Asbroeck
2020-11-10 17:06 ` Sven Van Asbroeck
2020-11-10 22:53 ` Andrew Lunn [this message]
2020-11-11 16:03 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110225334.GN1456319@lunn.ch \
--to=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=frdrc66@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jonathan.cameron@huawei.com \
--cc=juhosg@openwrt.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®