From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A98C9C388F9 for ; Wed, 11 Nov 2020 07:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72D5C207D3 for ; Wed, 11 Nov 2020 07:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726578AbgKKHUv (ORCPT ); Wed, 11 Nov 2020 02:20:51 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:60736 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726560AbgKKHUs (ORCPT ); Wed, 11 Nov 2020 02:20:48 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 2252C2003B; Wed, 11 Nov 2020 08:20:39 +0100 (CET) Date: Wed, 11 Nov 2020 08:20:37 +0100 From: Sam Ravnborg To: Yang Yingliang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, thierry.reding@gmail.com Subject: Re: [PATCH] drm/panel: add missing platform_driver_unregister() on error path Message-ID: <20201111072037.GA2950611@ravnborg.org> References: <20201111064425.3395558-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111064425.3395558-1-yangyingliang@huawei.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=i0EeH86SAAAA:8 a=-Gbx0BpZB59qaVUEe18A:9 a=CjuIK1q_8ugA:10 a=-RoEEKskQ1sA:10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yang, On Wed, Nov 11, 2020 at 02:44:25PM +0800, Yang Yingliang wrote: > If mipi_dsi_driver_register() failed, platform_driver_unregister() > need be called. > > Fixes: 210fcd9d9cf1 ("drm/panel: Add support for Panasonic VVX10F004B0") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thanks for the patch but this is already fixed in drm-misx-next. See: commit f2e66f212a9de04afc2caa5ec79057c0ac75c728 drm: panel: simple: add missing platform_driver_unregister() in panel_simple_init Sam