From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E08AC388F9 for ; Wed, 11 Nov 2020 11:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9FD22074B for ; Wed, 11 Nov 2020 11:31:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QU5fxZrG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726176AbgKKLbw (ORCPT ); Wed, 11 Nov 2020 06:31:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbgKKLbv (ORCPT ); Wed, 11 Nov 2020 06:31:51 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ECCFC0613D1 for ; Wed, 11 Nov 2020 03:31:51 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id o15so2201790wru.6 for ; Wed, 11 Nov 2020 03:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=U9WY4YwHoHsiLnMTjdtJfngq4inlaDzEyXm6ZeBp3Tk=; b=QU5fxZrGw6uKul6IuPlDVukJDFf/9w8mjopTg92s3jOuwPNLG2hAfJAdvlF9fg/Jz3 iLmd8sMlfvwdFCY4C8OrmeUQb4J5rvRMcHgbwQUcWNKZO3sct8Ge+6GCLmXLBfS/XF4X Yq7XWiwRPbpZsxvUo/W3+ZIn/9Eiyd1KNe9EHHTbSeoKl8JHJv5nmFUofGid71w3ZjDm hjuWawWuTkiix/v2wCtK1tyemtdfp4wJSL6firAUZYMqDWHy/hR7079/G4y3PBHy88N+ JJmPLFpPmjmsRb8YLdMt29Jt85/lzFMhMxuy3e9vb8ZK24eTRWuFhSko+r2BsdY9gikK TJqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U9WY4YwHoHsiLnMTjdtJfngq4inlaDzEyXm6ZeBp3Tk=; b=IQcGUofsD1716TpJzlbuzRzlMI/Sodrx1UBhZHfcHua4W1hSA+jZxJKLtGLeQtS6m0 puy49iNOP8DsXgd5/dTwXLV2PXyI/qU2tzbV6p51mj8FFkT1Pxd9U+uaksJ5Z80CoTP7 lKEYd82AKxKii5p9bzD3I6dFRE2UiXsX6USIFNo4w/6eOrPEJGNTwvg846BAljIBim+M pNXJ0OQCAYrRblAqKrnLGxNEZ+Lc5DpiMGSUdpqBqD9mOQUUGZAyos1eUjWTDLiTa6lO SEEQRxyAEwgrMCJ7iHlEIbmX5z8dtQS5eqnszhWzym4guGcdkDtE/qaOEVPa9He/jca3 48ZA== X-Gm-Message-State: AOAM531IbMHL5xj+r/1H2mT0A0F/kY2LKlORHGhRJqNFA1WzdBU4Kki4 6eazGgp8wEd6qx5n2jfkO012tw== X-Google-Smtp-Source: ABdhPJxdgoPMtvIpc8ik98fEm9DP705DkNY3XXFbPwfG7LegNZBJtunQHwh7cI5tVfwKzEHEOdLISA== X-Received: by 2002:adf:f3d1:: with SMTP id g17mr30133095wrp.156.1605094309513; Wed, 11 Nov 2020 03:31:49 -0800 (PST) Received: from google.com ([2a01:4b00:8523:2d03:2595:ed05:1717:fe6e]) by smtp.gmail.com with ESMTPSA id c17sm2213099wml.14.2020.11.11.03.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 03:31:48 -0800 (PST) Date: Wed, 11 Nov 2020 11:31:47 +0000 From: David Brazdil To: Marc Zyngier Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Morse , Julien Thierry , Suzuki K Poulose , Catalin Marinas , Will Deacon , Dennis Zhou , Tejun Heo , Christoph Lameter , Mark Rutland , Lorenzo Pieralisi , Quentin Perret , Andrew Scull , Andrew Walbran , kernel-team@android.com Subject: Re: [PATCH v1 01/24] psci: Accessor for configured PSCI version Message-ID: <20201111113147.ddoqadqaw6hcukow@google.com> References: <20201109113233.9012-1-dbrazdil@google.com> <20201109113233.9012-2-dbrazdil@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > + > > struct psci_operations { > > u32 (*get_version)(void); > > int (*cpu_suspend)(u32 state, unsigned long entry_point); > > I still maintain that populating .get_version in all cases instead of > duplicating an existing functionality is a better outcome. PSCI not > supported would be implied by .get_version being NULL. > > What breaks? Must have missed that suggestion before. Good idea, I'll do that.