From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Evan Green <evgreen@chromium.org>
Cc: Andy Shevchenko <andy@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: intel: Fix Jasperlake hostown offset
Date: Wed, 11 Nov 2020 14:16:29 +0200 [thread overview]
Message-ID: <20201111121629.GL4077@smile.fi.intel.com> (raw)
In-Reply-To: <CAE=gft4vdBytT2=tCbv2aE3RRoDut5CiHdBODjXJamGM5yB3Bw@mail.gmail.com>
On Tue, Nov 10, 2020 at 04:03:57PM -0800, Evan Green wrote:
> On Tue, Nov 10, 2020 at 3:48 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wednesday, November 11, 2020, Evan Green <evgreen@chromium.org> wrote:
> >>
> >> GPIOs that attempt to use interrupts get thwarted with a message like:
> >> "pin 161 cannot be used as IRQ" (for instance with SD_CD). This is because
> >> the JSL_HOSTSW_OWN offset is incorrect, so every GPIO looks like it's
> >> owned by ACPI.
> >
> >
> > Funny, I have created a similar patch few hours ago. Are you sure this is enough? In mine I have also padcfglock updated. But I have to confirm that, that’s why I didn’t send it out.
>
> Oh weird! I didn't check padcfglock since it didn't happen to be
> involved in the bug I was tracking down. I was trying to clean out
> some skeletons in my kernel closet [1] and debugged it down to this.
>
> If you want to smash the two patches together I'm fine with that. Let
> me know, and CC me if you do post something.
Can you test that 0x90 is correct value for padcfglock offset?
> [1] https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/master/overlay-dedede/sys-kernel/chromeos-kernel-5_4/files/0001-CHROMIUM-pinctrl-intel-Allow-pin-as-IRQ-even-in-ACPI.patch
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-11 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 22:49 Evan Green
[not found] ` <CAHp75VcfmJ6-cqCsZ6BjbghGDt+w-AbxGxLoWG61VVF2Knor-Q@mail.gmail.com>
2020-11-11 0:03 ` Evan Green
2020-11-11 12:16 ` Andy Shevchenko [this message]
2020-11-11 22:14 ` Andy Shevchenko
2020-11-11 23:16 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111121629.GL4077@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=evgreen@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®