From: Guenter Roeck <linux@roeck-us.net>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Shreyas Joshi <shreyas.joshi@biamp.com>,
shreyasjoshi15@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] printk/console: Allow to disable console output by using console="" or console=null
Date: Wed, 11 Nov 2020 14:52:48 -0800 [thread overview]
Message-ID: <20201111225248.GB211321@roeck-us.net> (raw)
In-Reply-To: <20201111135450.11214-3-pmladek@suse.com>
On Wed, Nov 11, 2020 at 02:54:50PM +0100, Petr Mladek wrote:
> The commit 48021f98130880dd74 ("printk: handle blank console arguments
> passed in.") prevented crash caused by empty console= parameter value.
>
> Unfortunately, this value is widely used on Chromebooks to disable
> the console output. The above commit caused performance regression
> because the messages were pushed on slow console even though nobody
> was watching it.
>
> Use ttynull driver explicitly for console="" and console=null
> parameters. It has been created for exactly this purpose.
>
> It causes that preferred_console is set. As a result, ttySX and ttyX
> are not used as a fallback. And only ttynull console gets registered by
> default.
>
> It still allows to register other consoles either by additional console=
> parameters or SPCR. It prevents regression because it worked this way even
> before. Also it is a sane semantic. Preventing output on all consoles
> should be done another way, for example, by introducing mute_console
> parameter.
>
> Link: https://lore.kernel.org/r/20201006025935.GA597@jagdpanzerIV.localdomain
> Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Signed-off-by: Petr Mladek <pmladek@suse.com>
Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> kernel/printk/printk.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index fe64a49344bf..ac440b879a2c 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2189,8 +2189,15 @@ static int __init console_setup(char *str)
> char *s, *options, *brl_options = NULL;
> int idx;
>
> - if (str[0] == 0)
> + /*
> + * console="" or console=null have been suggested as a way to
> + * disable console output. Use ttynull that has been created
> + * for exacly this purpose.
> + */
> + if (str[0] == 0 || strcmp(str, "null") == 0) {
> + __add_preferred_console("ttynull", 0, NULL, NULL, true);
> return 1;
> + }
>
> if (_braille_console_setup(&str, &brl_options))
> return 1;
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-11-12 1:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 13:54 [PATCH 0/2] printk/console: Use ttynull when no console is available or wanted Petr Mladek
2020-11-11 13:54 ` [PATCH 1/2] init/console: Use ttynull as a fallback when there is no console Petr Mladek
2020-11-11 16:36 ` Greg Kroah-Hartman
2020-11-11 22:52 ` Guenter Roeck
2020-11-11 23:58 ` Sergey Senozhatsky
2020-11-12 0:17 ` Sergey Senozhatsky
2020-11-12 1:45 ` Sergey Senozhatsky
2020-11-16 16:20 ` Petr Mladek
2021-01-06 23:36 ` ARC no console output (was Re: [PATCH 1/2] init/console: Use ttynull as a fallback when there is no console) Vineet Gupta
2021-01-07 9:02 ` John Ogness
2021-01-07 13:14 ` Greg Ungerer
2021-01-07 16:43 ` Vineet Gupta
2021-01-07 17:04 ` Petr Mladek
2021-01-07 17:58 ` Vineet Gupta
2021-01-08 3:48 ` Sergey Senozhatsky
2021-01-08 5:18 ` Vineet Gupta
2021-01-08 9:30 ` Petr Mladek
2021-01-13 22:07 ` Peter Korsgaard
2021-01-07 9:09 ` Richard Weinberger
2021-01-07 12:48 ` Petr Mladek
2021-01-07 15:27 ` [Buildroot] " Yann E. MORIN
2020-11-11 13:54 ` [PATCH 2/2] printk/console: Allow to disable console output by using console="" or console=null Petr Mladek
2020-11-11 22:52 ` Guenter Roeck [this message]
2020-11-11 23:59 ` Sergey Senozhatsky
2020-11-20 14:24 ` [PATCH 0/2] printk/console: Use ttynull when no console is available or wanted Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111225248.GB211321@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=shreyas.joshi@biamp.com \
--cc=shreyasjoshi15@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®