From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9ECC2D0A3 for ; Thu, 12 Nov 2020 15:22:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FAE522240 for ; Thu, 12 Nov 2020 15:22:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbgKLPWA (ORCPT ); Thu, 12 Nov 2020 10:22:00 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50894 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbgKLPV7 (ORCPT ); Thu, 12 Nov 2020 10:21:59 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kdEQ3-006fss-LP; Thu, 12 Nov 2020 16:21:51 +0100 Date: Thu, 12 Nov 2020 16:21:51 +0100 From: Andrew Lunn To: Wong Vee Khee Cc: Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ong Boon Leong , Voon Wei Feng Subject: Re: [PATCH net-next 1/1] net: phy: Add additional logics on probing C45 PHY devices Message-ID: <20201112152151.GA1456319@lunn.ch> References: <20201112150351.12662-1-vee.khee.wong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112150351.12662-1-vee.khee.wong@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 11:03:51PM +0800, Wong Vee Khee wrote: > For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to > check if there is at least one valid device ID, return 0 on true, and > -ENODEV otherwise. So does this mean you have a device which uses c45 and does not have any valid IDs? What device is it? Can it be used via c22? I would like to know more about why this is needed, since it sounds like a workaround for a broken device. Andrew