mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>, 王擎 <wangqing@vivo.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Samuel Zou" <zou_wei@huawei.com>,
	"Kurt Kanzenbach" <kurt@linutronix.de>,
	"Ivan Khoronzhuk" <ivan.khoronzhuk@linaro.org>,
	Networking <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR
Date: Thu, 12 Nov 2020 10:14:26 -0800	[thread overview]
Message-ID: <20201112181426.GC21010@hoboy.vegasvil.org> (raw)
In-Reply-To: <64177a8e-eb60-bc27-6d64-26234be47601@ti.com>

On Thu, Nov 12, 2020 at 12:05:25PM +0200, Grygorii Strashko wrote:
> But, as Richard mentioned [1], ptp_clock_register() may return NULL even if PTP_1588_CLOCK=y
> (which I can't confirm neither deny - from the fast look at ptp_clock_register()
>  code it seems should not return NULL)

This whole "implies" thing turned out to be a colossal PITA.

I regret the fact that it got merged.  It wasn't my idea.

I will push back on playing games with the Kconfig settings.  Even if
that happens to work for your particular driver, still the call site
of ptp_clock_register() must follow the correct pattern.

Why?  Because others will copy/paste it.

Thanks,
Richard

  reply	other threads:[~2020-11-12 18:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  9:24 Wang Qing
2020-11-11 12:32 ` Richard Cochran
2020-11-11 13:24   ` Grygorii Strashko
2020-11-11 13:55     ` Richard Cochran
2020-11-11 16:00       ` Jakub Kicinski
2020-11-12  1:15         ` 王擎
2020-11-12  1:32           ` Jakub Kicinski
2020-11-12  2:48             ` 王擎
2020-11-12  4:23               ` Jakub Kicinski
2020-11-12  8:25           ` Arnd Bergmann
2020-11-12 10:05             ` Grygorii Strashko
2020-11-12 18:14               ` Richard Cochran [this message]
2020-11-12 18:19             ` Richard Cochran
2020-11-12 21:21               ` Arnd Bergmann
2020-11-12 23:27                 ` Richard Cochran
2020-11-13 16:21                   ` Arnd Bergmann
2020-11-14 15:14                     ` Richard Cochran
2020-11-14 21:16                       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112181426.GC21010@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=arnd@kernel.org \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wangqing@vivo.com \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®