From: Kees Cook <keescook@chromium.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Colin Ian King <colin.king@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples/ftrace: mark my_tramp[12]? global
Date: Fri, 13 Nov 2020 10:57:38 -0800 [thread overview]
Message-ID: <202011131057.907A4449@keescook> (raw)
In-Reply-To: <20201113183414.1446671-1-samitolvanen@google.com>
On Fri, Nov 13, 2020 at 10:34:14AM -0800, Sami Tolvanen wrote:
> my_tramp[12]? are declared as global functions in C, but they are not
> marked global in the inline assembly definition. This mismatch confuses
> Clang's Control-Flow Integrity checking. Fix the definitions by adding
> .globl.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-11-13 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 18:34 Sami Tolvanen
2020-11-13 18:57 ` Kees Cook [this message]
2020-11-16 16:39 ` Steven Rostedt
2020-11-16 20:10 ` Sami Tolvanen
2020-11-16 20:38 ` Steven Rostedt
2020-11-16 21:10 ` Sami Tolvanen
2020-11-16 21:18 ` Steven Rostedt
2020-11-16 21:27 ` Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011131057.907A4449@keescook \
--to=keescook@chromium.org \
--cc=colin.king@canonical.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome