From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7F3C4742C for ; Fri, 13 Nov 2020 12:03:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E109C22240 for ; Fri, 13 Nov 2020 12:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726917AbgKMMDo (ORCPT ); Fri, 13 Nov 2020 07:03:44 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50829 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbgKMLnz (ORCPT ); Fri, 13 Nov 2020 06:43:55 -0500 Received: by mail-wm1-f67.google.com with SMTP id h2so7851717wmm.0 for ; Fri, 13 Nov 2020 03:43:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0SpwRyb0TuJ7zwVMJU26I/lRO0ner+Y643hGtbb0oXo=; b=OcxSB66aSQnoHa9k47M0EjaLM1bKsJt2z4cNnxUMEv64wcyGl9oYVGiBYmpZ9XF05Q ZCgzY07Euv4d9CBou+vQMUCEfawthzoq8IdH0OA4ib+3BokMfnbqQHYEVOk+yyS94pA0 YYTacdO8JBUc8h8LGse/X4eOISmosyTiHLXPQn/tCojyoeS5QmbLQgv5OHHLK9Gcki9w h3BFf0qngOSA+qffQ28tT3vBBl3+Y/guQlPDfRgNO8rdyFhZJKxHMb97B7JEHbkER2kK EKl0ETxX9Q2cBHbWQLyrpTUC35AQXFWP9RXw+Ry1l5/GT+Y39s+SmkvT81dgkj07uS+7 Zwgw== X-Gm-Message-State: AOAM5335x/UIhpBuAsuNLbOcOGf+Cmm0lsg/05fHfah7yyzYibeCWGwT UivTWTUW+4YcD1U3/H0nUMOZILnxkIU= X-Google-Smtp-Source: ABdhPJzto1ayTPSbWp7palp8RQsEdeA17/YLhio9PbL50h4Y4EuZ2MMQ01ikoHQxdq1b6CBwNb2qQA== X-Received: by 2002:a1c:2bc3:: with SMTP id r186mr1951868wmr.163.1605267209574; Fri, 13 Nov 2020 03:33:29 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id d2sm5489806wra.73.2020.11.13.03.33.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2020 03:33:29 -0800 (PST) Date: Fri, 13 Nov 2020 11:33:27 +0000 From: Wei Liu To: "Andrea Parri (Microsoft)" Cc: linux-kernel@vger.kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , linux-hyperv@vger.kernel.org, Andres Beltran , Michael Kelley , Saruhan Karademir , Juan Vazquez , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Subject: Re: [PATCH v9 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening Message-ID: <20201113113327.dmium67e32iadqbz@liuwe-devbox-debian-v2> References: <20201109100402.8946-1-parri.andrea@gmail.com> <20201109100402.8946-3-parri.andrea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109100402.8946-3-parri.andrea@gmail.com> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 11:04:01AM +0100, Andrea Parri (Microsoft) wrote: > From: Andres Beltran > > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in storvsc. In the face of errors or malicious > behavior in Hyper-V, storvsc should not expose or trust the transaction > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > use small integers generated by vmbus_requestor as requests > (transaction) IDs. > > Signed-off-by: Andres Beltran > Co-developed-by: Andrea Parri (Microsoft) > Signed-off-by: Andrea Parri (Microsoft) > Reviewed-by: Michael Kelley > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Cc: linux-scsi@vger.kernel.org Reviewed-by: Wei Liu