From: Peter Zijlstra <peterz@infradead.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Will Deacon <will@kernel.org>
Subject: Re: [RFC] lockdep: Put graph lock/unlock under lock_recursion protection
Date: Fri, 13 Nov 2020 12:54:16 +0100 [thread overview]
Message-ID: <20201113115416.GY2611@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201113110512.1056501-1-boqun.feng@gmail.com>
On Fri, Nov 13, 2020 at 07:05:03PM +0800, Boqun Feng wrote:
> A warning was hit when running xfstests/generic/068 in a Hyper-V guest:
>
> [...] ------------[ cut here ]------------
> [...] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled())
> [...] WARNING: CPU: 2 PID: 1350 at kernel/locking/lockdep.c:5280 check_flags.part.0+0x165/0x170
> [...] ...
> [...] Workqueue: events pwq_unbound_release_workfn
> [...] RIP: 0010:check_flags.part.0+0x165/0x170
> [...] ...
> [...] Call Trace:
> [...] lock_is_held_type+0x72/0x150
> [...] ? lock_acquire+0x16e/0x4a0
> [...] rcu_read_lock_sched_held+0x3f/0x80
> [...] __send_ipi_one+0x14d/0x1b0
> [...] hv_send_ipi+0x12/0x30
> [...] __pv_queued_spin_unlock_slowpath+0xd1/0x110
> [...] __raw_callee_save___pv_queued_spin_unlock_slowpath+0x11/0x20
> [...] .slowpath+0x9/0xe
> [...] lockdep_unregister_key+0x128/0x180
> [...] pwq_unbound_release_workfn+0xbb/0xf0
> [...] process_one_work+0x227/0x5c0
> [...] worker_thread+0x55/0x3c0
> [...] ? process_one_work+0x5c0/0x5c0
> [...] kthread+0x153/0x170
> [...] ? __kthread_bind_mask+0x60/0x60
> [...] ret_from_fork+0x1f/0x30
>
> The cause of the problem is we have call chain lockdep_unregister_key()
> -> <irq disabled by raw_local_irq_save()> lockdep_unlock() ->
> arch_spin_unlock() -> __pv_queued_spin_unlock_slowpath() -> pv_kick() ->
> __send_ipi_one() -> trace_hyperv_send_ipi_one().
>
> Although this particular warning is triggered because Hyper-V has a
> trace point in ipi sending, but in general arch_spin_unlock() may call
> another function having a trace point in it, so put the arch_spin_lock()
> and arch_spin_unlock() after lock_recursion protection to fix this
> problem and avoid similiar problems.
>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Works for me, thanks!
next prev parent reply other threads:[~2020-11-13 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:05 Boqun Feng
2020-11-13 11:54 ` Peter Zijlstra [this message]
2020-11-19 9:55 ` [tip: locking/urgent] " tip-bot2 for Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113115416.GY2611@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®