mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Jim Cromie <jim.cromie@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>
Subject: [PATCH] locking-selftest: add option to proceed through unexpected failures
Date: Fri, 13 Nov 2020 16:00:48 -0700	[thread overview]
Message-ID: <20201113230048.1200162-1-jim.cromie@gmail.com> (raw)

Locking selftest is currently (v.5.10-rc3) seeing 14 unexpected failures.
Add option to not disable debug_locks, so as to let it reveal any
locking flaws in new unrelated work.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 lib/locking-selftest.c | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index a899b3f0e2e5..87889bcf3232 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -41,6 +41,20 @@ static int __init setup_debug_locks_verbose(char *str)
 
 __setup("debug_locks_verbose=", setup_debug_locks_verbose);
 
+/*
+ * proceed thru debug fails, leave debugging enabled
+ */
+static unsigned int debug_locks_proceed;
+
+static int __init setup_debug_locks_proceed(char *str)
+{
+	get_option(&str, &debug_locks_proceed);
+
+	return 1;
+}
+
+__setup("debug_locks_proceed=", setup_debug_locks_proceed);
+
 #define FAILURE		0
 #define SUCCESS		1
 
@@ -2480,9 +2494,10 @@ void locking_selftest(void)
 
 	if (unexpected_testcase_failures) {
 		printk("-----------------------------------------------------------------\n");
-		debug_locks = 0;
-		printk("BUG: %3d unexpected failures (out of %3d) - debugging disabled! |\n",
-			unexpected_testcase_failures, testcase_total);
+		debug_locks = debug_locks_proceed;
+		printk("BUG: %3d unexpected failures (out of %3d) - debugging %s! |\n",
+		       unexpected_testcase_failures, testcase_total,
+		       (!debug_locks_proceed) ? "disabled" : "proceeding anyway");
 		printk("-----------------------------------------------------------------\n");
 	} else if (expected_testcase_failures && testcase_successes) {
 		printk("--------------------------------------------------------\n");
-- 
2.28.0


             reply	other threads:[~2020-11-13 23:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 23:00 Jim Cromie [this message]
2020-11-17 10:02 ` Peter Zijlstra
2020-11-24 21:27   ` jim.cromie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113230048.1200162-1-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®