mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kernel test robot <rong.a.chen@intel.com>
To: Wen Gong <wgong@codeaurora.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Kalle Valo <kvalo@codeaurora.org>
Subject: drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool
Date: Mon, 16 Nov 2020 13:53:19 +0800	[thread overview]
Message-ID: <20201116055212.GA3723@shao2-debian> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1
commit: 3c45f21af84eb05a355919abc80cf70a3a681cee ath10k: sdio: add firmware coredump support
compiler: nios2-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <rong.a.chen@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/net/wireless/ath/ath10k/sdio.c:2234:2: warning: Non-boolean value returned from function returning bool [returnNonBoolInBooleanFunction]
    return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
    ^

vim +2234 drivers/net/wireless/ath/ath10k/sdio.c

3c45f21af84eb05 Wen Gong 2020-08-18  2225  
3c45f21af84eb05 Wen Gong 2020-08-18  2226  static bool ath10k_sdio_is_fast_dump_supported(struct ath10k *ar)
3c45f21af84eb05 Wen Gong 2020-08-18  2227  {
3c45f21af84eb05 Wen Gong 2020-08-18  2228  	u32 param;
3c45f21af84eb05 Wen Gong 2020-08-18  2229  
3c45f21af84eb05 Wen Gong 2020-08-18  2230  	ath10k_sdio_read_host_interest_value(ar, HI_ITEM(hi_option_flag2), &param);
3c45f21af84eb05 Wen Gong 2020-08-18  2231  
3c45f21af84eb05 Wen Gong 2020-08-18  2232  	ath10k_dbg(ar, ATH10K_DBG_SDIO, "sdio hi_option_flag2 %x\n", param);
3c45f21af84eb05 Wen Gong 2020-08-18  2233  
3c45f21af84eb05 Wen Gong 2020-08-18 @2234  	return param & HI_OPTION_SDIO_CRASH_DUMP_ENHANCEMENT_FW;
3c45f21af84eb05 Wen Gong 2020-08-18  2235  }
3c45f21af84eb05 Wen Gong 2020-08-18  2236  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

             reply	other threads:[~2020-11-16  5:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-16  5:53 kernel test robot [this message]
2020-11-16  7:53 ` Kalle Valo
2020-11-16  9:33   ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201116055212.GA3723@shao2-debian \
    --to=rong.a.chen@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome