From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E0FC4742C for ; Mon, 16 Nov 2020 07:49:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD9A82227F for ; Mon, 16 Nov 2020 07:49:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="B8/I2oc8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbgKPHsk (ORCPT ); Mon, 16 Nov 2020 02:48:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:47702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgKPHsk (ORCPT ); Mon, 16 Nov 2020 02:48:40 -0500 Received: from localhost (unknown [122.171.203.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC70A2225E; Mon, 16 Nov 2020 07:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605512919; bh=orvkKSLE3qDSBwWd3ifg4y+FDRcfc/HXOtvw1V1r1Sc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B8/I2oc8lNFmKnMaVvVDwVfMYGoiEFJX/5balP2X9PRKAhX7zRdHpylefGXIUs7gD 8yjLvdPJgeV5e+TJWJnPdW37B7+usdWjPH73z4kopT5kgDFyrNYMYZZD1IsUsFRvQF 2szwO46TSUfW6m8lm1MVKif7wkD+ld/zxx0BIJrY= Date: Mon, 16 Nov 2020 13:18:35 +0530 From: Vinod Koul To: xiakaixu1987@gmail.com Cc: kishon@ti.com, linux-kernel@vger.kernel.org, Kaixu Xia Subject: Re: [PATCH] phy: mapphone-mdm6600: remove the unused variable error value assignment Message-ID: <20201116074835.GO7499@vkoul-mobl> References: <1605256482-5101-1-git-send-email-kaixuxia@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605256482-5101-1-git-send-email-kaixuxia@tencent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-11-20, 16:34, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia > > The value of variable error is overwritten by the following call > devm_request_threaded_irq() in phy_mdm6600_device_power_on(), so here the > value assignment is useless. Remove it. > > Reported-by: Tosk Robot > Signed-off-by: Kaixu Xia > --- > drivers/phy/motorola/phy-mapphone-mdm6600.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c > index 5172971..24ab848 100644 > --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c > +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c > @@ -421,7 +421,6 @@ static int phy_mdm6600_device_power_on(struct phy_mdm6600 *ddata) > dev_info(ddata->dev, "Powered up OK\n"); > } else { > ddata->enabled = false; > - error = -ETIMEDOUT; > dev_err(ddata->dev, "Timed out powering up\n"); Maybe the right fix is adding return error here..? -- ~Vinod