From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC6EC4742C for ; Mon, 16 Nov 2020 16:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76366222B9 for ; Mon, 16 Nov 2020 16:25:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="fTcQvCZG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732061AbgKPQZZ (ORCPT ); Mon, 16 Nov 2020 11:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732050AbgKPQZY (ORCPT ); Mon, 16 Nov 2020 11:25:24 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D8F2C0613D1 for ; Mon, 16 Nov 2020 08:25:22 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id d17so25936157lfq.10 for ; Mon, 16 Nov 2020 08:25:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9xG/1WZ4hUQEniTycexlF0Z4iE3+wzuenU4kk90ywzo=; b=fTcQvCZGCknts/NWYoWF0Fs/xydCjDT5R47q5L8XVSIQCtXgnpEvmEMywuwBAXCk2G pDUWrW36ijpFhxsKBQ2yprs3ExU7VW+RvmXR+nElMvwqjusEDhygn9d0vPdRGgO78kaG A3OhfXTUoMT8EtIxk8rC3XgFytVcCFHI8F63J9Ts9IXVHBsFCBrkRggkJHxGe1GwCmuR HHwE4rE5P9LElA0ptK7e6RJFaeaSNACP3m1PvvwNEfaK+R5leph9ahTAaPPHxdakdzli 8BH8gjargFPpYPjSTIwhXQ7E9wdF9lVeDDDyZia52sP05H+hFj2++7/AYYUKVpFOpwrE J30A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9xG/1WZ4hUQEniTycexlF0Z4iE3+wzuenU4kk90ywzo=; b=VJ2P/NUqMbxTrAN6junZ81vJe/g5uIo0aUgh5INPYQf/JxUTyF926WKJzw5Ivds5TW 5Rm16gr7fQH3+ReMlRrwhGdzof89JmoYAjsoov5/uIahG6RYXPfsQ/KrG59hAxV/Yjdx YJaBmZCipBLhwvPUthajPFHXZAd8Z1yPDDB8o4LoZVPx13JF6C9ISRh2GcKlBUvlBUQD YUhfps3hnSU3pfxb8frE1DWXozZSJ59g5j1ZvB5eruP64vJl1DpKVmIZEVew6UICv/GP otYYzn+hDLndkan1skJfObcWlXX/4nMgfjNUg3QfvOP8+u6QWj/0LpA/6ekvBbkaORnD ec/A== X-Gm-Message-State: AOAM531VpD5VEI3v5klK/d3b17ytG56MZWnuxcslvWBIW321bDb5+4H5 AePztiJGfs7NqQc2YpG2RFLPeA== X-Google-Smtp-Source: ABdhPJznVMQDd/DqjHtRUUctKXYAeZzd9Z0emVAQbGecQckp4yC+zEBPdGaEqNez4ohtfGKWQ92Exw== X-Received: by 2002:ac2:5199:: with SMTP id u25mr74800lfi.438.1605543920845; Mon, 16 Nov 2020 08:25:20 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id w199sm2790781lff.91.2020.11.16.08.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 08:25:20 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 3A492100F5E; Mon, 16 Nov 2020 19:25:19 +0300 (+03) Date: Mon, 16 Nov 2020 19:25:19 +0300 From: "Kirill A. Shutemov" To: Zi Yan Cc: linux-mm@kvack.org, Matthew Wilcox , "Kirill A . Shutemov" , Roman Gushchin , Andrew Morton , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Yang Shi , Michal Hocko , John Hubbard , Ralph Campbell , David Nellans Subject: Re: [RFC PATCH 3/6] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <20201116162519.f4n445yku3dp2fhw@box> References: <20201111204008.21332-1-zi.yan@sent.com> <20201111204008.21332-4-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111204008.21332-4-zi.yan@sent.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 03:40:05PM -0500, Zi Yan wrote: > From: Zi Yan > > It adds a new_order parameter to set new page order in page owner. > It prepares for upcoming changes to support split huge page to any lower > order. > > Signed-off-by: Zi Yan > --- > include/linux/page_owner.h | 7 ++++--- > mm/huge_memory.c | 2 +- > mm/page_alloc.c | 2 +- > mm/page_owner.c | 6 +++--- > 4 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h > index 3468794f83d2..215cbb159568 100644 > --- a/include/linux/page_owner.h > +++ b/include/linux/page_owner.h > @@ -31,10 +31,11 @@ static inline void set_page_owner(struct page *page, > __set_page_owner(page, order, gfp_mask); > } > > -static inline void split_page_owner(struct page *page, unsigned int nr) > +static inline void split_page_owner(struct page *page, unsigned int nr, > + unsigned int new_order) > { > if (static_branch_unlikely(&page_owner_inited)) > - __split_page_owner(page, nr); > + __split_page_owner(page, nr, new_order); Hm. Where do you correct __split_page_owner() declaration. I don't see it. -- Kirill A. Shutemov