From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74ACBC2D0A3 for ; Mon, 16 Nov 2020 18:09:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 472B620B80 for ; Mon, 16 Nov 2020 18:09:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730472AbgKPSIn (ORCPT ); Mon, 16 Nov 2020 13:08:43 -0500 Received: from foss.arm.com ([217.140.110.172]:44764 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729332AbgKPSIn (ORCPT ); Mon, 16 Nov 2020 13:08:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E31A30E; Mon, 16 Nov 2020 10:08:42 -0800 (PST) Received: from bogus (unknown [10.57.54.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9336B3F719; Mon, 16 Nov 2020 10:08:40 -0800 (PST) Date: Mon, 16 Nov 2020 18:08:37 +0000 From: Sudeep Holla To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Manivannan Sadhasivam , Hector Yuan , Viresh Kumar , Bjorn Andersson Subject: Re: [PATCH] dt-bindings: dvfs: Add support for generic performance domains Message-ID: <20201116180837.dgv6jhnqj76d5ral@bogus> References: <20201105173539.1426301-1-sudeep.holla@arm.com> <20201109201518.GA1679536@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109201518.GA1679536@bogus> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 02:15:18PM -0600, Rob Herring wrote: > On Thu, Nov 05, 2020 at 05:35:39PM +0000, Sudeep Holla wrote: > > The CLKSCREW attack [0] exposed security vulnerabilities in energy management > > implementations where untrusted software had direct access to clock and > > voltage hardware controls. In this attack, the malicious software was able to > > place the platform into unsafe overclocked or undervolted configurations. Such > > configurations then enabled the injection of predictable faults to reveal > > secrets. > > > > Many Arm-based systems used to or still use voltage regulator and clock > > frameworks in the kernel. These frameworks allow callers to independently > > manipulate frequency and voltage settings. Such implementations can render > > systems susceptible to this form of attack. > > > > Attacks such as CLKSCREW are now being mitigated by not having direct and > > independent control of clock and voltage in the kernel and moving that > > control to a trusted entity, such as the SCP firmware or secure world > > firmware/software which are to perform sanity checking on the requested > > performance levels, thereby preventing any attempted malicious programming. > > > > With the advent of such an abstraction, there is a need to replace the > > generic clock and regulator bindings used by such devices with a generic > > performance domains bindings. > > > > [0] https://www.usenix.org/conference/usenixsecurity17/technical-sessions/presentation/tang > > > > Cc: Rob Herring > > Signed-off-by: Sudeep Holla > > --- > > .../bindings/dvfs/performance-domain.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/dvfs/performance-domain.yaml > > > > diff --git a/Documentation/devicetree/bindings/dvfs/performance-domain.yaml b/Documentation/devicetree/bindings/dvfs/performance-domain.yaml > > new file mode 100644 > > index 000000000000..fa0151f63ac9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dvfs/performance-domain.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license new bindings. > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/dvfs/performance-domain.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Generic performance domains > > + > > +maintainers: > > + - Sudeep Holla > > + > > +description: |+ > > + This binding is intended for performance management of groups of devices or > > + CPUs that run in the same performance domain. Performance domains must not > > + be confused with power domains. A performance domain is defined by a set > > + of devices that always have to run at the same performance level. For a given > > + performance domain, there is a single point of control that affects all the > > + devices in the domain, making it impossible to set the performance level of > > + an individual device in the domain independently from other devices in > > + that domain. For example, a set of CPUs that share a voltage domain, and > > + have a common frequency control, is said to be in the same performance > > + domain. > > + > > + This device tree binding can be used to bind performance domain consumer > > + devices with their performance domains provided by performance domain > > + providers. A performance domain provider can be represented by any node in > > + the device tree and can provide one or more performance domains. A consumer > > + node can refer to the provider by a phandle and a set of phandle arguments > > + (so called performance domain specifiers) of length specified by the > > + \#performance-domain-cells property in the performance domain provider node. > > select: true > > Otherwise, this schema is never used. > > > + > > +properties: > > + "#performance-domain-cells": > > + description: > > + Number of cells in a performance domain specifier. Typically 0 for nodes > > + representing a single performance domain and 1 for nodes providing > > + multiple performance domains (e.g. performance controllers), but can be > > + any value as specified by device tree binding documentation of particular > > + provider. > > enum: [ 0, 1 ] > > If we need more, it can be extended. > > > + > > + performance-domains: > > Needs a type ref (phandle-array). > > > + description: > > + A phandle and performance domain specifier as defined by bindings of the > > + performance controller/provider specified by phandle. > > + > > +required: > > + - "#performance-domain-cells" > > + > > +additionalProperties: true > > + > > +examples: > > + - | > > + performance: performance-controller@12340000 { > > + compatible = "foo,performance-controller"; > > At some point in the future, this is going to generate warnings as an > undocumented binding. So we'll have to remove it, add a schema for it, > or replace with a real example. This is a standard DT design pattern, so > I'd lean toward removing the example. > Thanks for the review, I have fixed all other things pointed out. I have retained the example in v2 with real compatibles as I believe it is good to have an example for the new binding. I am happy to drop it if it still looks wrong. -- Regards, Sudeep