From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3871C2D0E4 for ; Tue, 17 Nov 2020 10:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B896221FC for ; Tue, 17 Nov 2020 10:20:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hx7OM4qW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgKQKUG (ORCPT ); Tue, 17 Nov 2020 05:20:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgKQKUG (ORCPT ); Tue, 17 Nov 2020 05:20:06 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01FC0C0613CF for ; Tue, 17 Nov 2020 02:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/K+4+Zm/ZKgF8bJkUMhAJ+qFtGVKkOc3Jr86ss2O0EM=; b=hx7OM4qWwP4IFbkWrOdoVny4BJ xmDTfQyihxlNbAZo7seF3pOAXvnjAdB+BI7u30SRaUXNKoVw/QFOvCYy6vhJNx6qJ8SeA1E7Y8/O9 5kUG5ra5vW+ffz+m7EpgQo+xTExXAV6a5DKJTPzgGqDQHOLPcOnoIW1u26I4mp8U/B0c5x3xaZ3VP jFLiDiJ501B2cGvyG+NgbKXYpGa5hkjm5lmvlW+HAnCmwYdHGtjcyorNrMcknjAH1QWm6afVRr78J ZhH7aUM7K/H2yH8d5dWOTj6ZANyMxXhXW42rdGYUpvsCRwK7HW4x7/V4xc7s8J1uOXLerA0sNwsDj SpUvNNaQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1key5c-0006A4-6O; Tue, 17 Nov 2020 10:19:56 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id D86E1304D28; Tue, 17 Nov 2020 11:19:54 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C2CB2200DCF08; Tue, 17 Nov 2020 11:19:54 +0100 (CET) Date: Tue, 17 Nov 2020 11:19:54 +0100 From: Peter Zijlstra To: Sami Tolvanen Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org, Sedat Dilek Subject: Re: [PATCH] perf/x86: fix sysfs type mismatches Message-ID: <20201117101954.GD3121406@hirez.programming.kicks-ass.net> References: <20201113183126.1239404-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113183126.1239404-1-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 10:31:26AM -0800, Sami Tolvanen wrote: > This change switches rapl to use PMU_FORMAT_ATTR, and fixes two other > macros to use device_attribute instead of kobj_attribute to avoid > callback type mismatches that trip indirect call checking with Clang's > Control-Flow Integrity (CFI). > > Reported-by: Sedat Dilek > Signed-off-by: Sami Tolvanen Thanks!