From: Mark Brown <broonie@kernel.org>
To: "Viorel Suman (OSS)" <viorel.suman@oss.nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Viorel Suman <viorel.suman@nxp.com>,
Lee Jones <lee.jones@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ASoC: ak4458: use reset control instead of reset gpio
Date: Tue, 17 Nov 2020 17:39:01 +0000 [thread overview]
Message-ID: <20201117173901.GH5142@sirena.org.uk> (raw)
In-Reply-To: <20201116222036.343635-1-viorel.suman@oss.nxp.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Tue, Nov 17, 2020 at 12:20:36AM +0200, Viorel Suman (OSS) wrote:
> static void ak4458_power_off(struct ak4458_priv *ak4458)
> {
> - if (ak4458->reset_gpiod) {
> - gpiod_set_value_cansleep(ak4458->reset_gpiod, 0);
> - usleep_range(1000, 2000);
> + if (ak4458->reset) {
> + reset_control_assert(ak4458->reset);
> + msleep(20);
We should really leave the support for doing this via GPIO in place for
backwards compatibility I think, we could mark it as deprecated in the
binding document. Otherwise this makes sense to me and solves a real
problem we have with the handling of resets so we should look into doing
this for new bindings.
One thing I'm not clear on is if there's some way to ensure that we
don't have different instances of the device resetting each other
without them noticing? Shouldn't be an issue in practice for the use
here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-17 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 22:20 Viorel Suman (OSS)
2020-11-17 17:39 ` Mark Brown [this message]
2020-11-17 18:17 ` Viorel Suman
2020-11-18 11:55 ` Mark Brown
2020-11-19 16:22 ` Viorel Suman
2020-11-19 16:27 ` Mark Brown
2020-11-19 12:48 ` Peter Ujfalusi
2020-11-19 16:24 ` Viorel Suman
2020-11-20 13:40 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117173901.GH5142@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
--cc=viorel.suman@nxp.com \
--cc=viorel.suman@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®