From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306AFC63777 for ; Wed, 18 Nov 2020 12:46:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D79C2246AE for ; Wed, 18 Nov 2020 12:46:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="WCfWgtAO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbgKRMqU (ORCPT ); Wed, 18 Nov 2020 07:46:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:53684 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbgKRMqT (ORCPT ); Wed, 18 Nov 2020 07:46:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605703578; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I+Qzkkhk4C6GtBU8xVUeEofjQe9CXbPuBs8NdbyYcoo=; b=WCfWgtAO+igB5OcpcKj8XOlT7ogXI+httgsZpXzYSpk3Km0SZhrb6ps0ZOT5fbIm96o19n vdUme6DBKNrcaRw6s/+riMxSYyKWQ6nn3SO4dsmP8RXVu+XeNwdfKVshKdhIM/P48G/xyx H/ktOrSgKNdjYtJKma1fDR8T0nAoays= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3BFBAAC91; Wed, 18 Nov 2020 12:46:18 +0000 (UTC) Date: Wed, 18 Nov 2020 13:46:17 +0100 From: Michal Hocko To: Lukas Bulwahn Cc: Roman Gushchin , Johannes Weiner , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, Vladimir Davydov , Arnd Bergmann , Tom Rix , Nathan Chancellor , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcg: remove obsolete memcg_has_children() Message-ID: <20201118124617.GR12284@dhcp22.suse.cz> References: <20201116055043.20886-1-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116055043.20886-1-lukas.bulwahn@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 16-11-20 06:50:43, Lukas Bulwahn wrote: > Commit 2ef1bf118c40 ("mm: memcg: deprecate the non-hierarchical mode") > removed the only use of memcg_has_children() in > mem_cgroup_hierarchy_write() as part of the feature deprecation. > > Hence, since then, make CC=clang W=1 warns: > > mm/memcontrol.c:3421:20: > warning: unused function 'memcg_has_children' [-Wunused-function] > > Simply remove this obsolete unused function. > > Signed-off-by: Lukas Bulwahn git grep agrees Acked-by: Michal Hocko > --- > applies cleanly on next-20201113, not on current master > > Roman, please ack. > > Andrew, please pick this minor non-urgent patch into your -next tree. > > mm/memcontrol.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index f95ddb3e9898..d49d7c507284 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3415,19 +3415,6 @@ unsigned long mem_cgroup_soft_limit_reclaim(pg_data_t *pgdat, int order, > return nr_reclaimed; > } > > -/* > - * Test whether @memcg has children, dead or alive. > - */ > -static inline bool memcg_has_children(struct mem_cgroup *memcg) > -{ > - bool ret; > - > - rcu_read_lock(); > - ret = css_next_child(NULL, &memcg->css); > - rcu_read_unlock(); > - return ret; > -} > - > /* > * Reclaims as many pages from the given memcg as possible. > * > -- > 2.17.1 -- Michal Hocko SUSE Labs