mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Christian Eggers <ceggers@arri.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Vladimir Oltean <olteanv@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kurt Kanzenbach <kurt@linutronix.de>
Subject: Re: [PATCH net-next 1/4] net: ptp: introduce enum ptp_msg_type
Date: Wed, 18 Nov 2020 05:18:47 -0800	[thread overview]
Message-ID: <20201118131847.GE23320@hoboy.vegasvil.org> (raw)
In-Reply-To: <20201117193124.9789-1-ceggers@arri.de>

On Tue, Nov 17, 2020 at 08:31:21PM +0100, Christian Eggers wrote:
> Using a PTP wide enum will obsolete different driver internal defines
> and uses of magic numbers.

I like the general idea, but ...

> +enum ptp_msg_type {
> +	PTP_MSGTYPE_SYNC        = 0x0,
> +	PTP_MSGTYPE_DELAY_REQ   = 0x1,
> +	PTP_MSGTYPE_PDELAY_REQ  = 0x2,
> +	PTP_MSGTYPE_PDELAY_RESP = 0x3,
> +};

I would argue that these should be #defines.  After all, they are
protocol data fields and not an abstract enumerated types.

For example ...

> @@ -103,10 +110,10 @@ struct ptp_header *ptp_parse_header(struct sk_buff *skb, unsigned int type);
>   *
>   * Return: The message type
>   */
> -static inline u8 ptp_get_msgtype(const struct ptp_header *hdr,
> +static inline enum ptp_msg_type ptp_get_msgtype(const struct ptp_header *hdr,
>  				 unsigned int type)
>  {
> -	u8 msgtype;
> +	enum ptp_msg_type msgtype;
>  
>  	if (unlikely(type & PTP_CLASS_V1)) {
>  		/* msg type is located at the control field for ptp v1 */

		msgtype = hdr->control;
	} else {
		msgtype = hdr->tsmt & 0x0f;

This assigns directly from protocol data into an enumerated type.

	}

	return msgtype;

Thanks,
Richard


      parent reply	other threads:[~2020-11-18 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 19:31 Christian Eggers
2020-11-17 19:31 ` [PATCH net-next 2/4] net: phy: dp83640: use " Christian Eggers
2020-11-17 19:31 ` [PATCH net-next 3/4] dpaa2-eth: " Christian Eggers
2020-11-17 19:31 ` [PATCH net-next 4/4] ptp: ptp_ines: " Christian Eggers
2020-11-17 23:17   ` kernel test robot
2020-11-17 23:24     ` Vladimir Oltean
2020-11-18 13:18 ` Richard Cochran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118131847.GE23320@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=ceggers@arri.de \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®