From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41064C5519F for ; Wed, 18 Nov 2020 20:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECF11246C2 for ; Wed, 18 Nov 2020 20:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727348AbgKRUqc (ORCPT ); Wed, 18 Nov 2020 15:46:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbgKRUqb (ORCPT ); Wed, 18 Nov 2020 15:46:31 -0500 Received: from ms.lwn.net (ms.lwn.net [IPv6:2600:3c01:e000:3a1::42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E72BC0613D4; Wed, 18 Nov 2020 12:46:31 -0800 (PST) Received: from lwn.net (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id D92282EF; Wed, 18 Nov 2020 20:46:30 +0000 (UTC) Date: Wed, 18 Nov 2020 13:46:29 -0700 From: Jonathan Corbet To: Alex Shi Cc: Andrew Morton , Yang Shi , "Kirill A. Shutemov" , David Rientjes , Zi Yan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] docs/vm: remove unused 3 items explanation for /proc/vmstat Message-ID: <20201118134629.31b3cdf8@lwn.net> In-Reply-To: <1605520282-51993-1-git-send-email-alex.shi@linux.alibaba.com> References: <1605520282-51993-1-git-send-email-alex.shi@linux.alibaba.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2020 17:51:22 +0800 Alex Shi wrote: > Commit 5647bc293ab1 ("mm: compaction: Move migration fail/success > stats to migrate.c"), removed 3 items in /proc/vmstat. but the docs > still has their explanation. let's remove them. > > "compact_blocks_moved", > "compact_pages_moved", > "compact_pagemigrate_failed", So a quick look says that the above-mentioned patch didn't remove those three items; two of them were, instead, renamed. Rather than just taking out the old information, it seems we should actually update it to reflect current reality? Thanks, jon