From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC95C5519F for ; Wed, 18 Nov 2020 13:55:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 120CD20872 for ; Wed, 18 Nov 2020 13:55:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ae/vBe3E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726223AbgKRNza (ORCPT ); Wed, 18 Nov 2020 08:55:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgKRNz3 (ORCPT ); Wed, 18 Nov 2020 08:55:29 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26CEEC0613D4 for ; Wed, 18 Nov 2020 05:55:29 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id w24so2814248wmi.0 for ; Wed, 18 Nov 2020 05:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=EOtSSeuOY9/kfAxGh8gbplfY1RBV3U9K8nR4s4raEd0=; b=Ae/vBe3EfmqC/FMwuAFEnvJHhBW5/Nv6iJTKL+D1z2GQSPCnOGY4JWL/SgbJFy0Wqw 7dS78uzPZE2ceuCuH7kH9HHgoAbCUvRZFHZRf7sIXRDU+ENN7+Aivnw1V7SlgkfUTmFb +3PojYAiA+eYg+1YiV/wppO1BO2MQwCX+OstLebCM8jc9z5CgNb6vOQs7ur91zXL7ziq MFsJdIgcey2dAHig5kAGCFIIGCgKXaqYgyOvsxBZCpo/V0ONrrW3VQ0FIpb2YKJcefWC KjosxfFuga27Wrwfr4D2/xjEIHLwlipJ7BXn0aMiJEcczDVDl9bNfuqk+2QxAbr/qdnZ SAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=EOtSSeuOY9/kfAxGh8gbplfY1RBV3U9K8nR4s4raEd0=; b=eU64nt69WotWU4nuJNlRpNk6Sjtlj0OK0lD6jRk+c9qZmRlL3oRDg9g4+RNSVJ+fzB NqwG0GWfHmFEOSFcpvYJltQr8ZnywCYYnzNu6sJEpay+sOoSCUPFLyYEimy3bpgFFXgz fyDcvvt5cBkYTt6fr/bc+3/C/9xsQrvVoZkyVlRd1qEyuwnptc6X6/sRgYHsESLoI5dX LbX5uhkjYmtCHpgfBQN1K7tJFlRvkfLHJv+M1Fss28l6Su8vfkVMCPPhfvmb7q2KQJuN ZM6Ur9m4uICRzXgMJC07A4m/E/Lwn5HJuPE2/HE3M2HYESnxlZX3EEB1ldswVSA0SAXU rMiA== X-Gm-Message-State: AOAM532Gm6B1VsPFuCKDbXGD0nWAS57zYPXO6simhQSMj72gTQjrJAfI Iq5y8C14KiVlwOwPZ3O2fpJrLg== X-Google-Smtp-Source: ABdhPJxjNhfbB51gdYoYsjFrofkZy+/pHb/HBijfCMmZzKYOQNukaKmsKTQSN0bFYJEF2v+74w50Nw== X-Received: by 2002:a1c:208f:: with SMTP id g137mr162567wmg.116.1605707727689; Wed, 18 Nov 2020 05:55:27 -0800 (PST) Received: from dell ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id y16sm31976731wrt.25.2020.11.18.05.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 05:55:27 -0800 (PST) Date: Wed, 18 Nov 2020 13:55:25 +0000 From: Lee Jones To: Colin King Cc: David Airlie , Daniel Vetter , Lyude Paul , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] drm/selftests/test-drm_dp_mst_helper: fix memory leak allocated to 'out' Message-ID: <20201118135525.GT1869941@dell> References: <20201118134901.461841-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201118134901.461841-1-colin.king@canonical.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Nov 2020, Colin King wrote: > From: Colin Ian King > > Currently when txmsg fails to allocate then there is a leak on 'out'. Fix > this by setting result to false and exiting via the clean up exit path. > Note since txmsg is NULL at this point, the kfree of txmsg is a no-op. > > Addresses-Coverity: ("Resource leak") > Fixes: 09234b88ef55 ("drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap") > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) This is fixed in my local branch. Looks like the wrong version of the patch was sent/applied. Either way, thanks for the fix Colin. Reviewed-by: Lee Jones > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > index 6b4759ed6bfd..dbac073ed385 100644 > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > @@ -131,8 +131,10 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) > return false; > > txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); > - if (!txmsg) > - return false; > + if (!txmsg) { > + result = false; > + goto out; > + } > > drm_dp_encode_sideband_req(in, txmsg); > ret = drm_dp_decode_sideband_req(txmsg, out); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog