From: Masami Hiramatsu <mhiramat@kernel.org>
To: Chen Yu <yu.chen.surf@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Chen Yu <yu.c.chen@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure correctly
Date: Wed, 18 Nov 2020 22:37:08 +0900 [thread overview]
Message-ID: <20201118223708.4b196db7bc1030f7604876ad@kernel.org> (raw)
In-Reply-To: <CADjb_WS+tc-oHX7hXVoWGz9pP_e66DcMp1npKbdpcVa9DhPKPA@mail.gmail.com>
On Tue, 17 Nov 2020 20:10:10 +0800
Chen Yu <yu.chen.surf@gmail.com> wrote:
> On Tue, Nov 17, 2020 at 5:53 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > Fix to check the write(2) failure including partial write
> > correctly and try to rollback the partial write, because
> > if there is no BOOTCONFIG_MAGIC string, we can not remove it.
> >
> > Fixes: 85c46b78da58 ("bootconfig: Add bootconfig magic word for indicating bootconfig explicitly")
> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> For [1/3] and [2/3]
> Tested-by: Chen Yu <yu.chen.surf@gmail.com>
Thank you Chen,
BTW, I found another bug in bootconfig error handling.
Steve, did you already pick this series? If not yet, I will update the seires to add that fix.
Thank you,
>
> --
> Thanks,
> Chenyu
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-11-18 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 9:52 [PATCH v3 0/3] tools/bootconfig: Align the bootconfig applied initrd Masami Hiramatsu
2020-11-17 9:52 ` [PATCH v3 1/3] tools/bootconfig: Fix to check the write failure correctly Masami Hiramatsu
2020-11-17 12:10 ` Chen Yu
2020-11-18 13:37 ` Masami Hiramatsu [this message]
2020-11-18 14:03 ` Steven Rostedt
2020-11-17 9:53 ` [PATCH v3 2/3] tools/bootconfig: Align the bootconfig applied initrd image size to 4 Masami Hiramatsu
2020-11-17 9:53 ` [PATCH v3 3/3] docs: bootconfig: Update file format on initrd image Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118223708.4b196db7bc1030f7604876ad@kernel.org \
--to=mhiramat@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=yu.c.chen@intel.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome