mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "Jürgen Groß" <jgross@suse.com>,
	"Andy Lutomirski" <luto@kernel.org>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Josh Poimboeuf" <jpoimboe@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Damien Le Moal" <Damien.LeMoal@wdc.com>,
	"X86 ML" <x86@kernel.org>
Subject: Re: WARNING: can't access registers at asm_common_interrupt
Date: Thu, 19 Nov 2020 13:01:22 +0100	[thread overview]
Message-ID: <20201119120122.GJ3121392@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20201119115059.dns4hvull3l3dwx3@shindev.dhcp.fujisawa.hgst.com>

On Thu, Nov 19, 2020 at 11:51:00AM +0000, Shinichiro Kawasaki wrote:
> I tried Peter's patch in my test system and result looks good. The warning is
> still observed with 5.10-rc4. With the patch on top of 5.10-rc4, the warning
> disappeared.

The patch on its own is not sufficient to fix things; there needs to be
an accompanying objtool patch to generate the correct unwind
information.

This patch only ensures objtool has enough information to be able to
dtrt, but as it stands it shouldn't even compile, it should complain
about an alternative trying to modify the stack and bail.

  reply	other threads:[~2020-11-19 12:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06  6:04 Shinichiro Kawasaki
2020-11-06 18:06 ` Josh Poimboeuf
2020-11-09  9:10   ` Shinichiro Kawasaki
2020-11-10  3:19     ` Josh Poimboeuf
2020-11-10  9:19       ` Shinichiro Kawasaki
2020-11-11 17:05 ` Josh Poimboeuf
2020-11-11 17:47   ` Peter Zijlstra
2020-11-11 18:13     ` Josh Poimboeuf
2020-11-11 18:46       ` Andrew Cooper
2020-11-11 19:42         ` Peter Zijlstra
2020-11-11 19:59           ` Josh Poimboeuf
2020-11-11 20:07             ` Peter Zijlstra
2020-11-11 20:15               ` Josh Poimboeuf
2020-11-11 20:25                 ` Andrew Cooper
2020-11-11 20:39                   ` Peter Zijlstra
2020-11-13 17:34                   ` Andy Lutomirski
2020-11-14  9:16                     ` Jürgen Groß
2020-11-14 18:10                       ` Andy Lutomirski
2020-11-15  6:33                         ` Jürgen Groß
2020-11-15 16:05                           ` Andy Lutomirski
2020-11-15 16:13                             ` Jürgen Groß
2020-11-16 11:56                     ` Jürgen Groß
2020-11-16 13:04                       ` Peter Zijlstra
2020-11-18  6:47                         ` Jürgen Groß
2020-11-18  8:22                           ` Peter Zijlstra
2020-11-19 11:51                             ` Shinichiro Kawasaki
2020-11-19 12:01                               ` Peter Zijlstra [this message]
2020-11-19 12:28                                 ` Jürgen Groß
2020-11-19 12:48                                 ` Shinichiro Kawasaki
2020-11-11 20:35                 ` Peter Zijlstra
2020-11-11 20:42       ` Peter Zijlstra
  -- strict thread matches above, loose matches on Subject: below --
2020-09-06 20:46 syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119120122.GJ3121392@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=Damien.LeMoal@wdc.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®