From: Peter Zijlstra <peterz@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: paulmck@kernel.org, jlayton@redhat.com, willy@infradead.org,
linux-cachefs@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: Can you help diagnose a weird failed wake?
Date: Thu, 19 Nov 2020 17:33:27 +0100 [thread overview]
Message-ID: <20201119163327.GT3121392@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <2220347.1605801222@warthog.procyon.org.uk>
On Thu, Nov 19, 2020 at 03:53:42PM +0000, David Howells wrote:
> timeo = wait_var_event_timeout(&cookie->stage, cookie_stage_changed(cookie, stage), 10*HZ);
> cookie->stage = stage;
> changed = true;
> break;
> }
> spin_unlock(&cookie->lock);
> if (changed) {
smp_mb(); // see comment on wake_up_bit() / wakequeue_active()
> wake_up_var(&cookie->stage);
prev parent reply other threads:[~2020-11-19 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:53 David Howells
2020-11-19 16:33 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119163327.GT3121392@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®