From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FACCC6379D for ; Thu, 19 Nov 2020 21:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03D0122255 for ; Thu, 19 Nov 2020 21:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727069AbgKSVLr (ORCPT ); Thu, 19 Nov 2020 16:11:47 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:47339 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726022AbgKSVLp (ORCPT ); Thu, 19 Nov 2020 16:11:45 -0500 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 8E693FF803; Thu, 19 Nov 2020 21:11:43 +0000 (UTC) From: Miquel Raynal To: Yu Kuai , paul@crapouillou.net, harveyhuntnexus@gmail.com, miquel.raynal@bootlin.com, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] mtd: rawnand: ingenic: remove redundant get_device() in ingenic_ecc_get() Date: Thu, 19 Nov 2020 22:11:42 +0100 Message-Id: <20201119211142.31720-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201031105439.2304211-1-yukuai3@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 9f14bf29d6ba0d18dc5175bbf22a07ec3dc67f23 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2020-10-31 at 10:54:39 UTC, Yu Kuai wrote: > of_find_device_by_node() already takes a reference to the device, and > ingenic_ecc_release() will drop the reference. So, the get_device() in > ingenic_ecc_get() is redundand. > > Fixes: 15de8c6efd0e("mtd: rawnand: ingenic: Separate top-level and SoC specific code") > Signed-off-by: Yu Kuai > Acked-by: Paul Cercueil Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel